Current Server Time: 09:50 (Central Europe)

#apertus IRC Channel Logs

2021/03/28

Timezone: UTC


01:13
aombk
left the channel
01:15
aombk
joined the channel
01:24
aombk
left the channel
01:26
aombk
joined the channel
01:49
aombk
left the channel
01:52
aombk
joined the channel
04:23
Bertl_oO
hp_dopeman[m]: really depends on what the reason for the overheadting is
04:24
Bertl_oO
could be fan which isn't enabled or some process which consumes a lot of CPU
05:47
vnksnkr
joined the channel
07:17
Bertl_oO
off to bed now ... have a good one everyone!
07:17
Bertl_oO
changed nick to: Bertl_zZ
07:46
abist
joined the channel
09:11
mumptai
joined the channel
09:43
markusengsner
joined the channel
09:54
abist
left the channel
10:04
BAndiT1983|away
changed nick to: BAndiT1983
10:23
abist
joined the channel
10:35
markusengsner
Good morning!
10:51
BAndiT1983
hi
10:57
markusengsner
I've looked some more into the Button states
10:57
markusengsner
And it seems to me like it might be best to integrate the color and state machine things into the IButton class
10:58
markusengsner
Since it's all stuff which is a fundamental part of being a button
10:59
markusengsner
and it would allow for a common interface for color setting when building GUIs
11:00
markusengsner
it does make IButton a bit larger though
11:06
BAndiT1983
battery in the laptop drained, when i was about to answer
11:06
BAndiT1983
the plan sounds exactly like what i've had in mind for that some months ago
11:07
BAndiT1983
am not forcing clean interfaces there, as we are in embedded environment and often things won't change, as hardware stays the same, so feel free to integrate common things into the interface, as long as they're not too big
11:08
BAndiT1983
usuall you would have something like IButton -> Button -> PushButton or MenuButton, where Button has the functionality and interface has only method definitions
11:12
markusengsner
I guess IButton could be split into a separate Interface and Base class at a later point, if the need arises
11:16
BAndiT1983
yep, exactly
12:41
BAndiT1983
even if the task is claimed, but no updates are there, then you can as in the main channel and if nobody bothers then just claim it
12:41
BAndiT1983
btw. just in case you don't know it, but if you add the task number to the commit message, like "T1161: Adjusted button states", then it will appear as reference in lab
12:43
BAndiT1983
forget it, have seen that you've already applied that ;)
12:58
vnksnkr
left the channel
13:14
satacker[m]
Hi
13:14
satacker[m]
Isn't it time we (students) discuss proposals?
13:15
BAndiT1983
hi satacker[m]
13:15
BAndiT1983
you can discussm, if you feel ready
13:15
BAndiT1983
is the challenge also solved already?
13:17
satacker[m]
Bertl has told me to look at coding style as far as challenge's task 1 is concerned
13:17
satacker[m]
had*
13:19
vnksnkr
joined the channel
13:40
mumptai
left the channel
14:44
vnksnkr
left the channel
15:13
vnksnkr
joined the channel
15:35
vnksnkr
left the channel
15:36
vnksnkr
joined the channel
15:56
vnksnkr
left the channel
16:03
markusengsner
left the channel
16:06
abist
left the channel
16:15
vnksnkr
joined the channel
17:22
Bertl_zZ
changed nick to: Bertl
17:23
Bertl
morning folks!
17:23
BAndiT1983
hi
17:34
satacker[m]
Hi
17:35
satacker[m]
I just saw that there's no task that requires Kernel Challenge
17:35
vnksnkr
hello
17:40
Bertl
satacker[m]: indeed, but maybe you come up with an idea where it makes sense or we add one ...
17:41
satacker[m]
Okay, that'll take some time. Thanks for clarification.
17:42
Bertl
we had, for example, a longer discussion about 'named' GPIO interfaces
17:43
Bertl
i.e. instead of having gpio42, this would present the respective gpio as something like i2c_nw_power_enable
17:44
satacker[m]
That seems nice. What was the decision regarding it?
17:44
satacker[m]
It will take time for me to go through upstream repository and changelog
17:44
Bertl
so if that is something you would like to work on, feel free to propose it as idea with some concept behind it
17:45
Bertl
i.e. how and where to set the names, how to handle 'discovery' etc
17:48
satacker[m]
Yes. mdev
17:48
vnksnkr
Bertl : I've tried to fix the indentations and the whitespaces..is the format correct now?
17:49
vnksnkr
https://github.com/vnksnkr/UART-SPI-BRIDGE-VHDL
17:49
Bertl
let me check ...
17:50
Bertl
no
17:51
Bertl
port( <- missing space before (
17:51
Bertl
indentation level of the closing parenthesis should be the same
17:51
Bertl
process(SCK) <- similar missing space
17:52
Bertl
and 'begin' is at the same level
17:53
Bertl
in spislave16.vhd there are a huge number of sporadic empty lines?
17:53
Bertl
is that for extra notes?
17:54
Bertl
empty lines make sense to separate blocks, like for example after an if block, before the else
17:54
Bertl
but they make little to none sense at 'end if' for example
17:56
Bertl
you are also missing a copyright notice and license information
17:57
vnksnkr
I guess I've done that in some other areas as well..I'll fix it right away
17:58
vnksnkr
do i need to add the license information in all files ?
17:58
BAndiT1983
changed nick to: BAndiT1983|away
17:58
Bertl
really depends on the license, for example for GPL, you want basically a 'one line' entry with your copyright which refers to the license
17:59
Bertl
and a license file somewhere
19:15
BAndiT1983|away
changed nick to: BAndiT1983
19:32
vnksnkr
I hope it's proper now ?
19:41
BAndiT1983
vnksnkr: just a tip, proper commit messages make it easier to track the history of the project and find certain commits
19:43
BAndiT1983
by committing a bunch of changed files and adding a message like "Added license header", would show people what actually happened there, instead of individual file commits with "Updated ..."
19:46
vnksnkr
I should have added that.. thanks for pointing that out..should i add comments instead to the recent commits ?
19:47
BAndiT1983
which comments do you mean?
19:48
vnksnkr
comments on the commit..isnt there an option to add comments to the already commited ones
19:49
BAndiT1983
it depends on the repo setup or features, but this was just an advice for next commits, as grouping last commits won't be that possible or fun
19:50
vnksnkr
sure..will make sure to add commit messages next time
20:09
vnksnkr
left the channel
20:48
markusengsner
joined the channel
21:29
comradekingu
joined the channel
22:38
markusengsner
left the channel
22:56
se6ast1an
off to bed, good night