#apertus IRC Channel Logs

Good Morning Everyone! :)

Hi Bertl_oO, what does oO mean?

Hey supragya!

interleaved means criss crossed, something like raw file given to us... however unsure of the context. Can you point me where you found it?

go to the ProcessingPresenter.cpp

see line 64 on same file

that is interleaving

hmm

putting it in a unidimensional array?

makes sense

yeah I didnt know the term xD

and then SetThumbnail creates a thumbnail from it

Ok! Thanks :P

was going to ask BAndiT once he is online

IAllocator is the StaticAllocator

go to memory folder

BAndiT1983_ hi

hi

interleaved is RGBRGBRGB....

however static linked

It's not in the guidelines, but I guess everything that starts with I is a Interface

I is also described in the guideline ;) second line

g++ -Wall -I Source/OCcore/ -I build/exports -L lib/libOCcore.so interact.cpp Source/OCcore/Image/*.cpp Source/OCcore/Log/*.cpp -pthread -fopenmp

i used the so... so is it dynamic?

yep, static files have .a as extension

this is snippet of most important lines that rand

prv.ReadBinaryFile(filename, filelength, fileData);

std::cout<<"File length: "<<filelength<<std::endl;

hmm

however these had problems

OC::DataProvider::OCImage FileFormat fmt;

declaration:

an interface is a special class which describes the methods inherited classes have to fill in

it has no own implementation usually, but i wouldn't restrict it hard in C++

OCImage contains loaded image data

so NULL seems right?

is the last parameter used in Load() at the moment?

and where is the header for OCImage?

it should be in OCcore/Images

OC::DataProvider::OCImage ocimg; doesn't seem to work for me

hii

ProcessingTest is used by what?

OC -> OCcore, OCui, OCLauncher, OCBackup, ProcessingTest

BAndiT1983_, the problem is that I am unable to instantiate the class OCImage, see above

also a test ground for new UI things

so it changes sometimes a lot, code aded and removed

also where is declaration of FileFormat

atom mostly

used atom before, but was too slow, switched fully to vscode

and now it showed me it....

mayank: here for GSoC?

BAndiT1983_ : why are there two of you on this channel ?

so when i log off it automatically changes to |away

it's a special setup by apertus guys

so it's personal thing

if you join gsoc, then you could also get this, in case there are urgent questions and the mentor is not there

hmmmm

Hmm

yes?

Image sequencer*

Ah

?

?

Where and how would it be done?

same suggestion like everyday -> ProcessingTest

let me have a look

at the bottom are 5 dng files and MOV clips

there you will find sequences

could not find bigger collection, but have a link to that somewhere

have you tried to adjust path?

have you tried to adjust path? - me or TofuLynx?

you can drag the image, zoom with mousewheel

I still couldn't put images on the processing test

Will have to try it later

next to the executable or use full path

2018-02-27 18:23:17,636 FATAL CRASH HANDLED; Application has crashed due to [SIGSEGV] signal

Aborted (core dumped)

but seems like there was memory corruption, you should try to debug

i dont know how to go about with QtCreator especially with no CMake support on the app i am making

seems like problem with static allocator

strange

but only the pool allocator part, as the frames have same size, usually

seems like it does

for performance reasons

[we should evaluate the lib i've posted yesterday] - don't really remember

BAndiT1983_ : trivial thing but seems like I was unnecesarily adding -L .so file... seems like linking is failing if i don't include the CPP files along with .h during compilation

static linking is something different than adding source folders

the code is compiled into there and chunks or whole lib is compiled into your application

g++ -Wall -I Source/OCcore/ -I build/exports interact.cpp Source/OCcore/Image/*.cpp Source/OCcore/Log/*.cpp Source/OCcore/Memory/*.cpp -pthread -fopenmp

okay BAndiT1983_ : i am able to now get RGB data back from OCcore through my console app

very good

with lodePNG perhaps I can save it to PNG...

let me check anyhow

so you learn the environment better

have you already played around with VS?

tried to create a script?

you should do it first, before starting the plugin

i will repeat my advice from yesterday: grab a video file, create VS script for frme serving, try to open the container in a video editor

then I can ask some meaningful questions

is for the predecessor, but applies more or less to VS also

yeah he corrected checksum, seems like it was wrong earlier

could somebody test his changes? TofuLynx, supragyaraj?

thansk

after I come back from run :)

he jsut explained what he has done, if you want to know details, then i can copy the content to you in your private channel

if you could sure, or forward the mail (*email address removed*) :)

Thank you BAndiT1983_ !!

What kind of commit was it? To fix kernel 4.9?

scripts

BAndiT1983_: A small correction with the new scriptsby medicineYeh: change ./guest-images/dev/microzed-image-1.3/build.sh to ./guest-images/dev/microzed-image-1.4/build.sh

could have made a PR but too small a fix to be a PR

supragya: just create a PR, even if small, so it'S documented

will do in a few hours

BAndiT1983: i am refraining to add the correction as a PR as the build system still has issues to be solved.

off to bed...

bandit

a image provider loads the image and then stores it?

and then it passes the image data to the image Loader?

imageprovider loads file content as-is and look, according to extension, which handler should process it further

*looks

check constructor of image provider, there the loaders are registered

yes, it inserts handlers into a map

finding extension is not done automatically yet, but rather simple to implement

from line 70 is the search and execution of loader

auto it

yes, it means auto iterator, auto is a new keyword in c++11

it gets the type automatically, using it when want to avoid writing long STL templated types

it reminds me of python

stl -> standard template library, is included in C++ for very long time, has many modules, check it out on google

yeah I sorta dislike python for not having types

what does this do?

look for c++ unordered_map

don't know python that much

((data[0] << 8 | data[1]) == 0x4d4d

where is it?

I think it's to check if the machine is little or small endian

but I dont understand how it works

4d is M

Ah!

CreateTIFFTagMap

it gets all the packages in the file

where is the method residing? don't have an IDE on at the moment

::Load

ah sorry

but tagnames is not used, so i suppose really debugging

it's there -> https://github.com/apertus-open-source-cinema/opencine/blob/e48ff3c781da233a025efc5ecaad4c972895c021/Source/OCcore/Image/ImageDefines.h

ok!

nevermind

tiff is based on tags?

that's why it's called tagged image file format

makes sense xD

ImageFormat::Integer12

confused*

OCui supports themes and widgets

of course

for drive and destination lists, also for thumbnail view in the middle

yeah I understand

why isn't the case here? It's easier this way?

i prefer dark applications for visual work

yes, they are, just look through OCui, it's not that big

Hmm

currentrly, OC Launcher does nothing, right?

looked through code, yes JSON file is used and buttons created according to it, also images bound

not yet

rather simple stuff

?

yes, as central point to start different modules

loved the handwritten OC image xD

there are some ideas for logos, also for ones of modules, in the lab

https://lab.apertus.org/T341

just call me

hmm

is OC Manager a planned module?

OCManager is the predecessor of backup, was meant for previewing and rating clips, export list of clips to PDF and so on

Ok! Understood! so the structure of OC is OCui, for the graphical user interfaces, OC Launcher so that user can choose the program from the OC suite, OCBackup is responsible for transfering images from drives to the computer

also old, as the name implies, it was meant for processing: debayering, color grading etc.

processingtest at the moment ;)

no, would search for better name then

Is there any part of the OC structure I have missed?

Ok! :)

Have you moved yet?

To dubai

not moving to dubai, moving to frankfurt main

Uh I had idea it was to Dubai, dunno why

Ok! Hope the moving goes nice! :)

I bet it requires a lot of patience

the heart is bleeding sometimes over some things, but if you don't use it for years then it can be removed

I have stored since my first year at school, when I was 7 years old, the books and memoriables and such of stuff. I don't know why I did it, but I simply stored the manuals. And when I had to toss them off It kinda of made me sad

especially when the girlfriend is standing behind you, hopefully without a frying pan

Ahahahaha

Good laugh

Get ready... If things get serious... xD

not alloy, aluminium

TofuLynx, have you found some area you would prefer to work on?

*although

gsoc or generally OC, if you are interested to contribute also outside of gsoc

And generally I would like to help with the OC image processing software

Haven't tried yet, I'm still trying to understand how processingtest works

it's easier to discover through starting and debugging

let me try it quick

some weeks ago, have removed some obsolete code

Ok! :)

opengl init is failing, have to check if 3d is activated

It uses 3D?

seems like latest virtualbox release is buggy, will get other guest additions

have a nice meal

hi

Back

wb

converting VB VM to vmware

hope it isn't totally broken after transfer

would like to have passthrough for graphics card

So how's it going?

have you a log when it is failing?

Not yet

either the output in the console or the logs folder in the build folder

Ok

I have to put the file where?

and a image appeared

why is the display image grayish?

and has some color artifacts on the margins

is it a color image?

alright, just no linearization/gamma, that's why it has some whitish tint

I chose a bad sample dng xD

it's the zombie one

the woman in red jacket

uh

12:50

another link from yesterday -> https://nofilmschool.com/2012/08/blackmagic-john-brawley-release-raw-cinema-camera-files-for-download

this was posted by me at 12:50 today, according to the log time

640mb

downloading

when I am in my university, i have 1gbps connection, but when I get home It's 20mbps :(

had 11 of 16mbps for years, last year in june finally got 50mbps

I live in a kinda of rural area, so fiber optic hasnt reached here

but there's a contract that stipulates that portugal has to get 100% fiber optic coverage before 2020, I think

Yeah I understand that

but then I changed to 4G

some days it's 20mbps, other days it's 40mbps

ADSL was rather unstable, but VDSL is solid

neverd heard

https://en.wikipedia.org/wiki/VDSL

Never heard about that

telekom is a monopoly, so getting fiber is not that easy

well the problem here is the inverse, there's a law that stipulates that in rural areas, if a company deploys fiber optic, its obligated to rent it to other companies, to avoid monopolies

btw

what do you suggest me to do next?

germany also decided laws which should enable more broadband, but it's like everywhere a mess on the market

also interesting fact

in mine is Portugal Telecom

you remember the thing with image preprocessor which reads only available pixels? you could start with that if oyu like

BayerFramePreProcessor?

yes, you can modify this one to enable skip of pixels or write new one

what do you mean skip of pixels? that thing to reduce the resolution to a half or so?

just to try to understand?

yes?

usually we know the bayer pattern

if you look at the image i've posted, there are individual layers shown

but wait, im sort of lost

look at the blue channel there, simple to explain that

the image you provided is a BGGR pattern?

I see

yeah it is

when this stuff is done, we can think about sending look up table to the fragment shader and correct the colors

found interesting online LUT generator some days ago

also called pixel shader in DirectX

ah

hey se6astian Bertl and BAndiT1983 : we made another pull request, which fixed lots of stuff :)

very nice, just read the PR

Can you continue the explanation BAndiT1983? :)

didn't knew about axiom mini

is there some prototype or just preparations?

Ok basically

Then you extract the information from the pixels to the respective color array

yes

*have to skip

Right?

but there are still some things to consider, especially about G channel

i mean in the 2x2 blocks

think of every 2x2 block as 1 pixel

of course, it's stored in DNG and is read by the decoder, otherwise it would be hard to process

you would read first G value nad one which is placed imageWidth - 1 further in array

then add them together and divide by 2 or multiply by 0.5

Shifting right 1*

why index + 1?

ah, yes, you can go through it in one step, just have to assign arrays in right order

Yeah

yes, take a look in OCcore, there you have examples for assigning of values to right folders

sorry, it's late, arrays

one can split even more, but at some point, after long optimization experiments i'Ve noticed, that i was using debug mode, so i've switched to release one and it processed faster than it read the data from the disk

1 for each color pixel

I can't imagine a way about using 2 threads for green0 and green1

you don't need it currently, worry about performance as last step

first algorithms and solid base, performance just when it's really slow

Premature optimization is the root of all devil

read yesterday an article about premature optimization and it said that at 97%, if one tries to squeeze last 3% out of the compiler, code and machine, it takes more time and effort, than it'S really worth it

still wondering that it works somehow

don't know, not working in the film industry

What time is it there? 23h?

you separated it in two extraction processes, one for odd rows and other for even rows

maybe there is a simple solution, thinking about the 2x2 blocks

so it should be fast enough

4 threads*

don't focus on threads, focus on the loop processing

hmm

what about

wait nvm, that doesnt make sense

hmm

the loop is rather simple, take rrgb as base first, afterwards we can convert it to dynamical assignment

you would have just 3 lines of code in the loop

by using + 1 in the dataUR

ok!

first line get red pixel and assigns it to the red array at position 0

blue does same as red

you don't even need row index

just reflecting in what i have implemented in the preprocessor

but it was probably done for jumps between rows, although an "if" could also do the same

uh?

it's half the image, but fast to get preview

but why do i need to remove the debayering step?

because you don't need it then, it'S more simpler

write another one and we will evaluate if it is better to merge the 2

ok!

so you suggested to do in a single loop

yes, you would process every 2x2 block

ok

not at all

it doesn't matter if you process 2x2 blocks

just for green values you have to add them and divide by 2

but there is a dataUR and a data LL

ah ok!

good night

good night!

hmm

so

why should the file be blank?

you said to make my own class

oh wait

this?

BayerFrameDownscaled::

not Downscaled, but it should be Downscaler to show that it is an actor

Downscaled suggests that it is a downscaled data container

and its variables would be

right?

Nah. I'm sorry. I really should go to bed

and functions?

void Convert12To16Bit() const;

take any you need over to your class, can still be reduced later

so, off for today

Bye bye!