#apertus IRC Channel Logs

I don't understand the mistake I'm committing. my red channel without any swapping looks like this: https://pasteboard.co/I2BjQqJ.png

Hello, I am a movie equipment maintenance engineer from China

I also want to make my own movie camera

please post the parts of code which do byte swap and also data split on pastebin, without some code it's only a guess

good day

Hello Bertl

Hello BAndiT1983, I have completed T872, how should I submit it?

best put it in a github repo and paste the url here

at a later time, when the actual GSoC submissions are due, you want to link it with your proposal

Yes I have tried to follow the guidelines but would love some criticism

Also the billinear interpolation, I added it as a dynamic library

Used camel casing, propoer variable names, and identation. But I have used tabs for identation, not 2 spaces as mentioned

as long as indentation is there, i won't complain

as the repo is probably public and it will be attached to the challenge task description for further processing, you can post it also here

alright

where is the libdebayer.so coming from?

why do you attach it as separate.so?

Sorry I was reading about dynamic linking today itself, how should I do it?

how would you structure such an application usually?

biggest complain first, everything is in the main()

oh alright

indentation and spacing is also weird

pre-compiled libs are a no-go for a project

oh, the tutorial I studied didn't use one, sorry I will try again with a better resource

not sure why folks can't get code formatting right ... it's not really rocket science is it? :)

Bertl: it can be rocket science, as i have xilinx ISE open at the moment, besides 4k display problem, one has to search many things to find the right option for formatting etc.

Or link me an article which you find good?

parimal: this tutorial is somehow off, in my opinion, to have some reusable lib you provide headers and of course .cpp files, which will be built, at the end you would have headers as API description and .so or .dll

it basically boils down to where to put spaces and where to avoid them consistently

just as an example from your code:

wow thanks, never knew there should be a space there :)

it's not hard to do it in cmake, but you should use second project, to have a clear line between the main application and the lib

braces should be in the new line for c++, same line is so java and javascript

Debayer(COLORImage,arrayImage, width, height);

That function is from the dyanmic library I created, the libdebayer.so file, it calls the function from there

ColorImage is probably better

Okay

okay noted

because it will not use native register sizes on some architectures

so in general, you want to go for strict sized types for stuff you need the specific size and int, long, long long for anything which doesn't care

there also fast versions

the test_char() vs test_int() is a good example of this

uint16_t will result in the same extension as test_char()

hallo

I shared my repo, would you liek to have a lookj too please? :)

hi supragya_raj

hmm

i haven't got any explanation beforehand, so i also lack details to tell them

you can create a sample picture or so

let me have a look myself... hang on

Bertl: next page shows fast versions, which should fit the platform

is in the logs

yep, please split the code in functions

seems quite a monolithic code

Should I drop dynamic linking or work on it as you suggested?

dynamic linking can be done when everything else is done

alright I will learn it from a better resource

yes, should I share the pasteboard link?

as the code looks a bit shaky there

supgraya_raj, yes I will do that.

line 53-57 looks not correct for splitting

BAndiT1983, I have tried them on paper, it was converting 12 bits into 8 bits correctly

hm, looks like you are converting without swapping, which works here, but not for general usage

yes

parimal: is the mask really required if you already shift by 4 to the left?

but in my opinion its a hacky solution which only fits the task somehow, in real processing you need every bit of information from raw

Oh alright, I have another way which I read, would you like to have a look?

i hope you also understand what is done there and not only copying the code

also I went through parimal's code which runs great but is very heavily reproduced form TofuLynx's last year's code. im unable to understand the essence of the task if we don't make it all by ourselves

hi rohan_ :)

yes there are few changes, but yet not original

Yes I read the logs from last year, and studied the algorithms. I understand the code supragya_raj:)

students should show what they are capable of

rohan_: I understand the issue... we take these things into consideration, don't worry

How would the code be any different for billinear interpolation?

thank you supragya_raj. I'm still working on my code. will show it to you guys as soon as I make more progress

we are issuing challenge tasks, to filter out best students

there was no concept of ppm files last year, how can rohan_ just blame me that I reproduced it from TofuLynx?

*variables

Yes, true, it was mentioned we can use other resources as long as we mention them, I will add the repo link for him too

And code it from scratch I guess

this debayering is not my favourite, as it is monolithic as hell

Do you suggest any other way? Since I studied it from this article -http://www.stark-labs.com/craig/articles/assets/Debayering_API.pdf

Billinear interpolation, and his code does the same :)

the conversion and debayering is same, yes

BAndiT1983: can we take out NN and Bilinear off the table then?

nearest neighbor

this are perfect sub-tasks for evaluation, i'm not that much interested in final results, but in proper structure

optimizations are not a requirement

BAndiT1983: can I ask why we posted all the repos (for everyone to see) in T872 last time? Maybe that is where this problem is stemming from?

also they are public, so visible for everyone, also without forking to apertus repo

there are many ways to solve either debayering method in code

another reference: https://github.com/codeplaysoftware/visioncpp/wiki/Example:-Bayer-Filter-Demosaic

So I should try it again, with all the criticism :)

try to split the debayering code, which would show that you really understood it, as the code is monolithic

This is regarding T734 , I have a naive idea , how to make histgram from a raw12 file .

I understood that we will be connecting to axiom beta and passing arguments through our system .

2- how we are taking these values cmv_base , cmv_size , map_size , are these are predefined values what they signify ?

ASHU, these values are hardware specific for our image sensor

Hello se6astian ,

ASHU: probably you need this -> https://wiki.apertus.org/index.php/CMV12000_Register_Blocks

as my naive idea was to simply after getting buffer , I will hash values to get histogram .

first thing i would adjust there, is the double loop, which is usually not required and can be replaced by linear one

we are trying to get histogram that acts as a graphical representation of the tonal distribution in a digital image , right?

are talking about the line #292 , double loop

https://lab.apertus.org/T734

maybe still double loop, as it should also crop image, but it can be done solely through limits in the loop description

I understood how program is taking arguments and memory mapping taking place(using mmap) .

very good

" first it is about readability, as some pointer calculations" : yes i will try to take it in account .

ASHU: the code is not mine, so i would have to read through it, but don't have time at the moment

you could take parts of the code and create separate application, load bitmap data there and let it run through it, so you can check what it does

okay , thank you very much I will try that .

: )

good night