| 01:45 | futarisIRCcloud | left the channel |
| 02:56 | Bertl_oO | off to bed now ... have a good one everyone!
|
| 02:56 | Bertl_oO | changed nick to: Bertl_zZ
|
| 03:01 | futarisIRCcloud | joined the channel |
| 07:08 | se6ast1an | good day
|
| 07:15 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 07:50 | se6ast1an | hi BAndiT1983!
|
| 07:51 | BAndiT1983 | hi
|
| 10:44 | RexOrCine | Greets.
|
| 10:45 | BAndiT1983 | hi RexOrCine
|
| 10:55 | se6ast1an | hi rex, how are things going?
|
| 11:01 | RexOrCine | I have my senses but I haven't won the lottery yet.
|
| 11:03 | RexOrCine | I think things would possibly be going more back to the old normal, but the fact is people like sitting in their houses, playing Modern Warfare and getting paid for it.
|
| 11:05 | BAndiT1983 | maybe you should try the other group, which is not playing MW, but advertises beauty products
|
| 11:05 | RexOrCine | left the channel |
| 11:05 | RexOrCine | joined the channel |
| 12:28 | Bertl_zZ | changed nick to: Bertl
|
| 12:28 | Bertl | morning folks!
|
| 12:33 | BAndiT1983 | hi
|
| 14:00 | www2 | joined the channel |
| 14:07 | www2 | hi i have ask some time at go (2018) about apertus and light-field i have found this: https://www.k-lens.de/en/home
|
| 14:12 | RexOrCine | www2: Interesting. Thanks.
|
| 15:49 | Dest123 | joined the channel |
| 15:53 | megora | joined the channel |
| 16:36 | BAndiT1983 | panintended: looked at your fork, button highlighting works very good, like it would on the hardware, but i'm not that happy with the if/else waterfall in VirtualUI.cpp, we should check if there are optimizations possible, as it's hard to get the logic there
|
| 16:37 | BAndiT1983 | there was a question in imgui issues about releasing buttons outside, which used ButtonBehaviour or so
|
| 16:40 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 18:20 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 18:25 | Dest321 | joined the channel |
| 18:29 | Dest123 | left the channel |
| 18:52 | Dest321 | left the channel |
| 19:02 | panintended | Hi BAndiT1983 Thanks for checking it out. Yeah, I'm also not terribly proud of my implementation there. The special circumstance in our case is that we need to keep track both of (A) the change of state of a button and (B) whether this happens inside the button or not. And based on the combinations of these two, we need to act differently.
|
| 19:03 | panintended | I had a look at the ButtonBehavior flag before, let me see if a fresh look will help :)
|
| 19:04 | BAndiT1983 | hi panintended
|
| 19:04 | BAndiT1983 | will try to find t he issue again, where they've discussed very similar stuff
|
| 19:05 | panintended | thanks. beyond this, what do you think of the new button properties organization + iterating over the array to render buttons?
|
| 19:12 | BAndiT1983 | fitting the case, but we need to dissect the button IDs and events, i mean in the firmware, otherwise it's everything in one place and is making some things difficult
|
| 19:46 | BAndiT1983 | panintended: finally found the thread, maybe it has some advices -> https://github.com/ocornut/imgui/issues/2971
|
| 19:46 | panintended | thanks
|
| 19:57 | panintended | hmmm, yes, that's the option I looked at last week. While we can use ImGuiButtonFlags_PressedOnClickRelease, ImGuiButtonFlags_PressedOnClickReleaseAnywhere etc. in my understanding these only define under what circumstances the ImGui::Button() call returns true
|
| 19:57 | panintended | let me think it over again for a few mins
|
| 20:04 | BAndiT1983 | no rush, just trying to understand the options, as i had no time to dive into it yet
|
| 20:05 | panintended | ok, I think I got it
|
| 20:05 | panintended | it looks like it's working. and, gosh, is the code simpler now!
|
| 20:07 | BAndiT1983 | :D
|
| 20:07 | BAndiT1983 | can i pull?
|
| 20:08 | comradekingu | left the channel |
| 20:08 | panintended | ah, give me another 10 minutes please :)
|
| 20:08 | BAndiT1983 | no problem, take your time
|
| 20:08 | comradekingu | joined the channel |
| 20:13 | metal_dent[m] | off to bed... good night!!
|
| 20:15 | Bertl | nn
|
| 20:19 | panintended | BAndiT1983:
|
| 20:20 | panintended | have a look now. keep in mind that this still doesn't handle the knob button
|
| 20:23 | panintended | ah, please hang on a minute. I missed a file when staging...
|
| 20:25 | panintended | ok, I've pushed that as well. whenever you're ready then :)
|
| 20:40 | panintended | By the way. I think it would be a good idea to use a namespace for the code (i.e. put all of the code under an axiom:: namespace), to make things explicit and avoid conflicts amongst other.
|
| 20:41 | panintended | For example I have a conflict of the enum class Button with ImGui::Button
|
| 20:43 | panintended | It seems more fitting to actually have the enum class Button named as ButtonEvent. But regardless of the naming of this, namespacing the code would be a good step IMO. I'd like your feedback also when you get the time
|
| 20:45 | panintended | off to bed, good night ppl
|
| 20:48 | BAndiT1983 | panintended: namespace is a good idea, using it not often, but should
|
| 20:48 | se6ast1an | heading off too, but good points we should discuss tomorrow!
|
| 21:07 | Bertl | off for now ... bbl
|
| 21:07 | Bertl | changed nick to: Bertl_oO
|
| 21:34 | Dest123 | joined the channel |
| 21:36 | Dest123 | left the channel |
| 21:49 | chelsea[m] | joined the channel |
| 22:44 | megora | left the channel |
| 23:52 | BAndiT1983 | changed nick to: BAndiT1983|away
|