23:09 | Bertl_oO | off to bed now ... have a good one everyone!
| |
23:09 | Bertl_oO | changed nick to: Bertl_zZ
| |
23:20 | rton | left the channel | |
23:40 | ymc98 | joined the channel | |
23:42 | ymc98 | Bertl : I'd like to get started on T731 and it'd be great if you could provide resources for the same.
| |
23:59 | RexOrCine | I should imagine that Herbert will be back in around six hours.
| |
00:00 | RexOrCine | (but he checks chat logs)
| |
00:26 | ymc98 | left the channel | |
02:58 | MK | joined the channel | |
05:38 | MK | left the channel | |
05:40 | MK | joined the channel | |
05:43 | MK | Guys can anyone tell me how to add my code for review?
| |
06:04 | [simon] | joined the channel | |
06:05 | [simon] | Hi, I just ended the c++ challenge where I have to submit it?
| |
06:06 | supragya | joined the channel | |
06:14 | [simon] | If I don't have a task proposal for GSoC I can choose one of those related with the challenge I made and that are displayed here https://lab.apertus.org/project/view/20/?
| |
06:16 | supragya | hi [simon], can you elaborate? do you want to propose something from Qualification tasks?
| |
06:20 | [simon] | left the channel | |
06:22 | supragya | ah yes, you can choose from one of the related tasks, for which you have done the qualification challenge. (make sure you don't do VHDL challenge when applying for kernel btw) :)
| |
06:26 | Kjetil | left the channel | |
06:26 | futarisIRCcloud | left the channel | |
06:26 | _florent_ | left the channel | |
06:26 | Kjetil_ | joined the channel | |
06:26 | futarisIRCcloud | joined the channel | |
06:26 | _florent_ | joined the channel | |
06:37 | [simon] | joined the channel | |
06:42 | [simon] | left the channel | |
06:45 | [simon] | joined the channel | |
06:48 | [simon] | (if I want to see the history of the channel is there a way to display it in my irc client?)
| |
06:49 | supragya | you can check the IRC logs
| |
06:50 | supragya | I cannot see other way of doing so... until you are from apertus :)
| |
06:50 | supragya | irc.apertus.org
| |
06:50 | [simon] | a ok
| |
06:51 | [simon] | supragya, for what concerns the previous question, if I want to apply to one of the tasks I have to do the weekly schedule?
| |
06:56 | supragya | left the channel | |
07:06 | supragya | joined the channel | |
07:07 | supragya | [simon], yes weekly schedule are a part of GSoC proposal
| |
07:08 | [simon] | but if I starting a new project where I don't know how would it take to make it or how difficult it can be how can I do a weekly schedule?
| |
07:08 | [simon] | left the channel | |
07:13 | se6astian|away | changed nick to: se6astian
| |
07:16 | [simon] | joined the channel | |
07:32 | rton | joined the channel | |
07:35 | supragyaraj | joined the channel | |
07:38 | supragyaraj | [simon], your proposal should put forth your motivation and understanding of the task along with the way you think it should be tackled. It is obvious that things will change during summer, and you are free to mention such buffer time in your proposal. However, the weekly schedules are there for both your and mentor's understanding of what and when the deliverables can be expected.
| |
07:38 | TofuLynx | joined the channel | |
07:40 | [simon] | left the channel | |
07:42 | supragyaraj | if you are starting a new project... you should understand the task thoroughly(or atleast have a general sense of what is expected), figure out how difficult it is and then put forth your proposal. Note that weekly schedules are great way to keep track of time and deliverables, but you will not be failed in evaluations just because things moved ahead or before your expectations. Still, keep it as close to what you plan to do in summer :)
| |
07:46 | TofuLynx | Good morning supragyaraj
| |
07:49 | supragyaraj | left the channel | |
07:50 | TofuLynx | Bertl_zZ: Can you explain what do you mean by "- error handling needs some improvements"
| |
07:50 | TofuLynx | ?
| |
07:53 | sebix | joined the channel | |
08:02 | TofuLynx | left the channel | |
08:20 | [simon] | joined the channel | |
08:22 | supragya | left the channel | |
08:30 | [simon] | left the channel | |
08:37 | [simon] | joined the channel | |
08:38 | [simon] | left the channel | |
08:39 | [simon] | joined the channel | |
08:40 | [simon] | left the channel | |
08:43 | [simon] | joined the channel | |
08:44 | [simon] | left the channel | |
09:17 | BAndiT1983 | joined the channel | |
09:21 | BAndiT1983 | MK: have you solved your problem with adding code for review?
| |
09:28 | Bertl_zZ | changed nick to: Bertl
| |
09:28 | Bertl | morning folks!
| |
09:33 | Bertl | rahul_: the focus peaking should probably go in the middle of the image pipeline (beginning of the output pipeline), but we will decide where to put it exactly
| |
09:35 | Bertl | TD-Linux: there are always a number of cases why something goes wrong (e.g. opening a file, allocating memory) and the user expects some clue what caused the failure (e.g. permission problem, file does not exist, etc)
| |
09:36 | rahul_ | okay, In my proposal should I add the AXI Stream and AXi lite interface as well? or just pixel data_in (RGB+EOL+EOF) and Pixel clock.
| |
09:44 | Bertl | no need for the AXI interface, but it requires (stream) input and output
| |
09:45 | Bertl | so basically we will tap off between when the memory is fetched (via AXI) and before the data is sent to TMDS encoding
| |
09:45 | Bertl | the generated information (peaking) will be put into an overlay for the video data (i.e. mixed in)
| |
09:51 | MK | Bertl, I didn't add it for reviewing yet any help will be appreciated also can i send my proposal draft to you on mail to check it out?
| |
09:52 | Bertl | you may, but I'd prefer it if you uploaded it as draft on the google GSoC site or paste a link to it either here or in PM
| |
09:53 | Bertl | an yes, of you have some challenge code or proposal to review, I'll gladly do it
| |
09:53 | Bertl | s/of/if/
| |
10:07 | skat00sh_ | joined the channel | |
10:30 | [simon] | joined the channel | |
10:46 | rahul_ | Bertl, is there any specific template format for Apertus, that I need to follow.
| |
10:50 | Bertl | there is no specific proposal template, but make sure to link some CV and put in a detailed description and timeline what you plan to do
| |
10:51 | Bertl | it also is a good idea to make it look nice and appealing (think CV) and thus avoid things like Microsoft Word or similar (go for TeX, LaTeX or so)
| |
10:57 | rahul_ | thank you for the insight
| |
10:59 | BAndiT1983 | Bertl: are you also avoiding libreoffice and such?
| |
11:01 | rahul_ | Yes, I will provide the proposal based on LaTEX.
| |
11:09 | Bertl | BAndiT1983: well, libreoffice basically tries to do what the Microsoft Office package does ... it does it a little better but it is still no comparison to proper type setting (as with LaTeX)
| |
11:10 | Bertl | I'm also fine with Google Docs as long as they are not looking too ugly :)
| |
11:10 | Bertl | (after all it is Google SoC :)
| |
11:14 | [simon] | left the channel | |
11:22 | [simon] | joined the channel | |
11:29 | [simon] | left the channel | |
11:31 | BAndiT1983 | Bertl: met a lot of people who are know nothing about software development etc., so latex is a problem, as they also don't know HTML and similar
| |
11:32 | BAndiT1983 | many managers still write VBA scripts for excel, that says it all
| |
11:32 | Bertl | well, there is Lyx for those who need/want a GUI for LaTeX
| |
11:33 | Bertl | (which does a decent job keeping you from fingering around with the formatting :)
| |
11:33 | BAndiT1983 | still like the feature to add custom tags to latex a lot, we used it for ABM already
| |
11:33 | Bertl | s/Lyx/LyX/
| |
11:35 | BAndiT1983 | would like to use latex in the company, but i'm afraid that my colleagues would block it right away, although it would get rid of badly formatted word docs when several people adjusted them already
| |
11:36 | Bertl | Microsoft Word documents look ugly even when you don't mess with the formatting (which everybody does)
| |
11:37 | BAndiT1983 | it depends how it was done, also know several people who have done their diploma/master thesis in word, switched to latex for mine back when, as word broke my layout
| |
11:37 | Bertl | IMHO it can be considered a 'notepad' with a gazillion useless features ... use it as that and you're fine
| |
11:38 | BAndiT1983 | *back then
| |
11:38 | Bertl | you would not submit a hand written note on a piece of paper as 'documentation' or 'application' either
| |
11:38 | BAndiT1983 | you forget about people with little technical knowledge, a secretary wouldn't hack text into LyX
| |
11:38 | Bertl | why not?
| |
11:39 | BAndiT1983 | fear of computer technology
| |
11:39 | Bertl | it actually would take away the required technical know-how from said secretary
| |
11:40 | Bertl | he or she would not have to 'learn' how to 'work' with the text processor but could focus on entering text
| |
11:40 | Bertl | (which after all, is what they are supposed to do in your example)
| |
11:52 | Bertl | MK: checking the updated challenge task now ...
| |
11:53 | MK | Bertl, thanks
| |
11:55 | Bertl | quite nicely formatted now ... only a tiny number of missing spaces
| |
11:55 | Bertl | and great work on the license/copytight
| |
11:56 | Bertl | on the semantic part, I wonder, have you tested this code with a real FPGA toolchain (i.e. further than synthesis)?
| |
11:57 | MK | Bertl, actually no the task required only a VHDL code
| |
11:58 | Bertl | okay, because there are some constructs in your VHDL which have a good chance to fail on almost any real world toolchain/FPGA
| |
11:59 | Bertl | for example having conditions on rising_edge() _and_ falling_edge() of the same signal in the same process usually doesn't end well
| |
12:00 | MK | i know what you are about should i change them ?
| |
12:00 | MK | *talking
| |
12:01 | Bertl | I'm fine if you're aware of the problems (maybe add a note to the code what the problem is and how you could/would work around it)
| |
12:06 | MK | left the channel | |
12:17 | skat00sh_ | left the channel | |
12:20 | MK | joined the channel | |
12:21 | MK | Bertl, sure i will add a comment
| |
12:32 | supragyaraj | joined the channel | |
12:39 | sebix | left the channel | |
12:47 | anuejn | Bertl, BAndiT1983: there is also pandoc which creates nicely formatted latex documents from markdown, which is quite intuitive even for non cs people
| |
12:47 | supragyaraj | hi BAndiT1983
| |
12:48 | supragyaraj | downscaler should resize the frame (to 1/4 for example) or it just does not calculate the skipped frames and the framesize remains the same?
| |
12:54 | TofuLynx | joined the channel | |
12:56 | TofuLynx | supragyaraj, the frame is automatic
| |
12:56 | TofuLynx | it takes the size from the OCimage it gets
| |
12:56 | TofuLynx | so it resizes accordingly to the image
| |
12:58 | TofuLynx | Bertl, did you see my question?
| |
12:58 | supragyaraj | because if this happens, the AVI frames will shift inside the file and it wont be possible to change quality "on the fly" :)
| |
12:58 | supragyaraj | Bertl saw your question, however maked it with TD-Linux rather than TofuLynx :)
| |
12:58 | supragyaraj | see logs
| |
12:58 | TofuLynx | ah i suspected that
| |
12:59 | TofuLynx | but, Bertl, I think I covered every case, I don't see what I am missing
| |
13:01 | TofuLynx | supragyaraj, not sure if I understood you, but you want the frame to resize automatically?
| |
13:02 | supragyaraj | in short... AVI is a header + frame + frame + ...
| |
13:02 | TofuLynx | yeah, continue
| |
13:02 | supragyaraj | and this is just calculated, not made fully in FrameServer
| |
13:02 | supragyaraj | so when bytes are requested, they are provided
| |
13:02 | TofuLynx | hmm
| |
13:02 | supragyaraj | there is an external app that will control the quality (downscale)
| |
13:03 | TofuLynx | and do you think the view part (from VMP model) can't handle that?
| |
13:03 | BAndiT1983 | left the channel | |
13:03 | supragyaraj | if an app reads header and then reads framedata, and then we switch the quality (on the fly), then the frame locations will change
| |
13:03 | TofuLynx | Oh I see
| |
13:03 | TofuLynx | hmm
| |
13:03 | TofuLynx | what if...
| |
13:03 | supragyaraj | TofuLynx, It has nothing to do with view part
| |
13:04 | TofuLynx | the downscaler resizes the result?
| |
13:04 | supragyaraj | for the other application, it is not being frameserved, it is reading AVI from disk
| |
13:04 | TofuLynx | basically, subsampling
| |
13:04 | supragyaraj | TofuLynx, that is what i am asking, as pixels are less
| |
13:04 | TofuLynx | Yeah I would suggest subsampling
| |
13:05 | supragyaraj | i am asking the current state of the downscaler - resize or subsampling... because it then affects FS
| |
13:05 | TofuLynx | currently it's resizing
| |
13:06 | TofuLynx | but I could add some sort of a flag check system to resize or subsample
| |
13:06 | TofuLynx | as per your needs
| |
13:06 | supragyaraj | also, the point of downscaling is improve performance, so less number of bytes are maybe good
| |
13:06 | supragyaraj | TofuLynx, do that please! :)
| |
13:06 | TofuLynx | hmm
| |
13:06 | TofuLynx | I will have to edit my proposal
| |
13:07 | supragyaraj | if I will be using your downscaler, then subsampling would be nice... although it is not a big task on it's own...
| |
13:07 | TofuLynx | Yeah, it's probably just simple maths
| |
13:07 | supragyaraj | And i think BAndiT1983 would say to work with resized ones anyways
| |
13:07 | MK | left the channel | |
13:08 | TofuLynx | We could talk to him
| |
13:12 | [simon] | joined the channel | |
13:20 | [simon] | left the channel | |
13:46 | sebix | joined the channel | |
13:46 | sebix | left the channel | |
13:46 | sebix | joined the channel | |
13:52 | sebix | left the channel | |
13:59 | supragyaraj | left the channel | |
14:10 | Bertl | changed nick to: Bertl_oO
| |
14:11 | [simon] | joined the channel | |
14:11 | [simon] | left the channel | |
15:06 | TofuLynx_ | joined the channel | |
15:06 | [simon] | joined the channel | |
15:06 | TofuLynx_ | left the channel | |
15:17 | se6astian | changed nick to: se6astian|away
| |
15:28 | [simon] | is it Only me or apertus lab is not working
| |
15:34 | supragya | joined the channel | |
15:34 | supragya | lab is down
| |
15:35 | anuejn | woks for me :)
| |
15:36 | supragya | this too anuejn ? -> https://lab.apertus.org/tag/google_summer_of_code_2018/
| |
15:36 | supragya | ah... works for me too
| |
15:37 | supragya | seen some trouble today at lab however... few hours ago wasn't working for me
| |
15:54 | supragya | left the channel | |
16:01 | [simon] | my friend's phone work but mine not lol
| |
16:04 | supragya | joined the channel | |
16:35 | BAndiT1983|away | changed nick to: BAndiT1983
| |
16:36 | supragya | hi BAndiT1983
| |
16:36 | sebix | joined the channel | |
16:36 | sebix | left the channel | |
16:36 | sebix | joined the channel | |
16:36 | BAndiT1983 | hi supragya
| |
16:37 | BAndiT1983 | hi TofuLynx
| |
16:37 | supragya | BAndiT1983, have refactored AVIEncoder
| |
16:37 | supragya | can you look it and perhaps run it at your end?
| |
16:38 | BAndiT1983 | i will take a quick look, but will try to run it later or in the next days, as i've entered home just minutes ago
| |
16:39 | supragya | I am beginning to couple the AVIEncoder with libfuse now... finally will couple with OCcore when it is done
| |
16:39 | BAndiT1983 | very good
| |
16:40 | BAndiT1983 | your loops for synthetic frames can be made simpler and faster
| |
16:40 | supragya | how? pointers?
| |
16:40 | BAndiT1983 | width / 3 repeats itself a couple of times, this can be extracted, otherwise the software would calculate it at every iteration, possibly also multiple times
| |
16:40 | BAndiT1983 | no, just create a local variable for it
| |
16:41 | BAndiT1983 | this would hold the value and no recalculation required
| |
16:41 | MK | joined the channel | |
16:41 | supragya | okay
| |
16:41 | BAndiT1983 | you can also avaoid double loops, just calculate the right stuff inside the loop, then your index calculation will shrink
| |
16:42 | BAndiT1983 | i'm not a fan of C style, but it will work for now
| |
16:42 | supragya | C style as in char*?
| |
16:42 | BAndiT1983 | your code looks more like C and not C++
| |
16:43 | BAndiT1983 | char* can be replaced with std::string, e.g. fileName
| |
16:44 | MK | left the channel | |
16:44 | supragya | how about the maintainance thing... header calculations are put into different functions as you asked
| |
16:44 | MK | joined the channel | |
16:44 | supragya | guess I will have to refactor again (c -> C++)
| |
16:45 | BAndiT1983 | later
| |
16:45 | BAndiT1983 | focus on functionality for now
| |
16:45 | supragya | sure :)
| |
16:45 | BAndiT1983 | there is no point to move such small calculations to other files or methods
| |
16:46 | supragya | for the headers?
| |
16:46 | BAndiT1983 | ?
| |
16:46 | BAndiT1983 | ah, i've thought about other calcs
| |
16:46 | BAndiT1983 | no your way is fine for now
| |
16:46 | supragya | okay
| |
16:47 | MK | left the channel | |
16:47 | BAndiT1983 | you should use -> using namespace ... in .cpp files, to avoid cluttering it up with namespace::
| |
16:47 | MK | joined the channel | |
16:47 | supragya | does using namespace span accross files or is file specific?
| |
16:48 | BAndiT1983 | another thing which occurred to me some days ago, do we really need to calculate header sizes? most headers were fixed or am i mistaken?
| |
16:48 | BAndiT1983 | using namespace ... is only for the file
| |
16:48 | supragya | We don't need that calculations, it is 220 bytes only
| |
16:48 | supragya | for this reason only, I have put it all into AviContainer::calculateSize(sizeType type)
| |
16:49 | supragya | so that we can hardcode this easily later if we want, without changing much
| |
16:49 | BAndiT1983 | looked at it, so the question came up
| |
16:49 | BAndiT1983 | ok
| |
16:50 | BAndiT1983 | you can also avoid setting struct members to 0
| |
16:50 | supragya | yes, that is one thing
| |
16:50 | BAndiT1983 | if you want to ensure that all of them are zero at the beginning, then try memset
| |
16:50 | supragya | however, doesn't it becomes zero when we instantiate?
| |
16:51 | BAndiT1983 | usually yes, just wanted to ensure
| |
16:51 | supragya | will do, however in next refactor
| |
16:53 | BAndiT1983 | if you do new ..., then it should be zeroed
| |
16:53 | BAndiT1983 | and you should really consider to allocate through new
| |
16:54 | danieeel | joined the channel | |
16:56 | BAndiT1983 | supragya, haven'T looked deep enough into that stuff, but maybe a pool allocator would also help to speed things up
| |
16:57 | supragya | I am not looking into pool allocator for now... would like to just frameserve this avi first before anything
| |
16:57 | supragya | I can build on top of it...
| |
16:57 | supragya | is it okay that way?
| |
16:58 | danieel | left the channel | |
16:58 | BAndiT1983 | don't worry, was just some consideration for later
| |
17:00 | supragya | also, there was one thing that came up
| |
17:00 | supragya | subsampling vs resizing while downscaling
| |
17:01 | supragya | what are we going to do there... if we resize, then headers need to be rewritten and the final app needs a new read of header
| |
17:01 | supragya | all the offsets change too...
| |
17:02 | supragya | we can subsample, but I guess that won't be very efficient computationally
| |
17:04 | se6astian|away | changed nick to: se6astian
| |
17:05 | BAndiT1983 | what do you mean but subsampling etc.?
| |
17:07 | supragyaraj | joined the channel | |
17:08 | supragya | left the channel | |
17:09 | supragyaraj | BAndiT1983, if we have 100x100 image and quality set to 1/2, the resulting frame is 100x100 or 50x50?
| |
17:10 | BAndiT1983 | i would say 50/50
| |
17:10 | BAndiT1983 | for 1:1 we need some interpolation, but quick one would be sufficient for preview
| |
17:11 | supragyaraj | then we cannot do that "on the fly" for FrameServer...as it changes header and framesize
| |
17:11 | BAndiT1983 | ?
| |
17:11 | BAndiT1983 | i know what you mean
| |
17:11 | BAndiT1983 | but it was never considered to do it on the fly
| |
17:11 | BAndiT1983 | user has to stop frameserver or just serving and reconfigure the file to his needs
| |
17:12 | BAndiT1983 | more important is the "on the fly" thing for frame serving, evrything else can be set when servinf was paused
| |
17:13 | BAndiT1983 | let'S evaluate it when we have some working solution, to see how other apps behave
| |
17:13 | supragyaraj | if however we fill every alternate pixel with nearest value, we can sample it up to constant framesize and then it becomes same "on the fly"
| |
17:14 | [simon] | for the c++ submit in aperture lab, do I have to write an action on the topic with the url of the github repo?
| |
17:16 | supragyaraj | BAndiT1983, can you explain this? [more important is the "on the fly" thing for frame serving, evrything else can be set when servinf was paused]
| |
17:21 | se6astian | [simon]: for the c++ submit in aperture lab, do I have to write an action on the topic with the url of the github repo? <- you simply "edit task" and add you github url and nickname in the appropriate place
| |
17:21 | supragyaraj | [simon], can you give the github link?
| |
17:21 | supragyaraj | I will post it up if you are facing problems :)
| |
17:24 | [simon] | https://github.com/Symon97x/GoogleSummerOfCode.git
| |
17:25 | [simon] | thank you supragyaraj
| |
17:26 | supragyaraj | it should be up now.. kindly check
| |
17:29 | [simon] | a ok now it works
| |
17:29 | [simon] | I have an account in lab aperture...I'll try to add it
| |
17:41 | BAndiT1983 | [simon], you shouldn't commit binary executables to github
| |
17:41 | [simon] | ok I'll remove them
| |
17:41 | TofuLynx | hey BAndiT1983
| |
17:42 | supragyaraj | use .gitignore feature Simon :)
| |
17:42 | BAndiT1983 | supragyaraj, we cannot change settings on the fly, like resolution, so the usetr has to stop the server, adjust what he wants and start server again
| |
17:42 | BAndiT1983 | hi TofuLynx
| |
17:42 | TofuLynx | Okay so the subsampling question is solved, it seems
| |
17:42 | TofuLynx | hmm Andrej, are you occupied right now?
| |
17:51 | Bertl_oO | TofuLynx: yeah, sorry about the wrong prefix in my reply ...
| |
17:51 | Bertl_oO | regarding errorhandling, here three examples:
| |
17:51 | Bertl_oO | non existing file: Couldn't open specified file!
| |
17:51 | Bertl_oO | file without permissions: Couldn't open specified file!
| |
17:52 | Bertl_oO | empty file (zero size): Invalid width or height dimensions! Perhaps they are too big or too small?
| |
17:52 | TofuLynx | Hmm?
| |
17:52 | Bertl_oO | the first two definitely lack to provide some information why it failed
| |
17:52 | TofuLynx | I see the point
| |
17:52 | TofuLynx | thanks!
| |
17:52 | Bertl_oO | the third one is just misleading because you probably start to fiddle with args 2 and 3
| |
17:52 | BAndiT1983 | TofuLynx, yes, have to do other stuff, not at computer at the moment
| |
17:53 | TofuLynx | what do you mean by fiddling with args 2 and 3?
| |
17:54 | Bertl_oO | argument 2 and 3 are the width and height
| |
17:54 | Bertl_oO | the error suggests that something is wrong with them
| |
17:54 | Bertl_oO | (when it is the file :)
| |
17:54 | Bertl_oO | btw, I will be doing in depth reviews/testing this weekend (on the GSoC challenge tasks) so that's a good chance for folks to improve ...
| |
17:55 | TofuLynx | yes, and why is it misleading?
| |
17:55 | Bertl_oO | because it should say that the file is empty or doesn't contain enough data
| |
17:55 | TofuLynx | oh!
| |
17:55 | TofuLynx | Ok! Roger!
| |
17:58 | TofuLynx | also Bertl_oO , what do you mean by good chance to improve? you will be providing feedback?
| |
18:02 | Bertl_oO | yep
| |
18:02 | TofuLynx | Ok! :)
| |
18:09 | supragyaraj | [simon], by binary executables, BAndiT1983 did not mean to say the raw12 file, he meant a.out file :)
| |
18:10 | supragyaraj | take the a.out file out of the repo. Use .gitignore
| |
18:11 | [simon] | aaaaa ok lol
| |
18:49 | sebix | left the channel | |
19:36 | supragyaraj | left the channel | |
19:42 | niemand | joined the channel | |
19:42 | niemand | left the channel | |
19:42 | niemand | joined the channel | |
20:06 | [simon] | left the channel | |
20:14 | [simon] | joined the channel | |
20:29 | BAndiT1983 | changed nick to: BAndiT1983|away
| |
20:30 | MK | Bertl_oO, I finished the first draft of the wiki please take a look it is on the same repo as the task under wiki
| |
20:32 | Bertl_oO | found it, checking now ...
| |
20:35 | Bertl_oO | first comment: let's avoid CamelCase in VHDL :)
| |
20:37 | Bertl_oO | I agree with process labels, but I don't understand the comment there: "If you can't it is because it either do too much work or sometimes too little"
| |
20:38 | Bertl_oO | I/O ports are always (special) 'signals' and should be handled like them, i.e. they are definitely not constants
| |
20:38 | Bertl_oO | generics on the other hand can (and probably should) be treated like constants
| |
20:39 | Bertl_oO | on the suffix part, there are a few 'useful' notations I've seen so far and which I try to use in my code like:
| |
20:40 | Bertl_oO | _d, _dd, _d<n> for delayed versions of a signal
| |
20:40 | Bertl_oO | _v for variables
| |
20:40 | seku | joined the channel | |
20:41 | Bertl_oO | _f for functions
| |
20:42 | Bertl_oO | _i, _o and _t for input, output, tristate of one signal
| |
20:42 | Bertl_oO | _s for a state
| |
20:42 | Bertl_oO | _a for an array type
| |
20:43 | Bertl_oO | _n for a negated signal
| |
20:43 | Bertl_oO | _clk for a clock signal
| |
20:43 | MK | Bertl_oO, By the process label i mean sometimes the developer puts everything in one process and add all the signals to the sensitivity list and everything works but the name won't be any good
| |
20:44 | Bertl_oO | main : process (all) :)
| |
20:44 | MK | but is this right ?
| |
20:44 | Bertl_oO | well, sometimes that's fine, but usually not, I agree, but I wouldn't have interpreted your comment as that
| |
20:45 | Bertl_oO | so maybe try to rephrase it
| |
20:45 | Bertl_oO | and I think it would be a good idea to make some examples regarding spaces around operators and indentation for various statements
| |
20:46 | Bertl_oO | because folks keep getting this part wrong ...
| |
20:48 | MK | how can i rephrase this comment? what do you think?
| |
20:49 | Bertl_oO | maybe just with some general statements about block length?
| |
20:49 | Bertl_oO | like keep processes and functions small and specialized with a meaningful label
| |
21:21 | giacomoalbe | joined the channel | |
21:27 | se6astian | changed nick to: se6astian|away
| |
21:33 | MK | Bertl_oO, what is wrong with camelCase ?
| |
21:35 | niemand | left the channel | |
21:46 | giacomoalbe | left the channel | |
21:52 | Bertl_oO | MK: almost everything ... it's hard to read and it opens a can of work regarding how to handle lowerCaseNames vs UpperCaseNames
| |
21:53 | Bertl_oO | I know C++ folks love it, but for C and VHDL (and Python) it's a bad idea IMHO
| |
21:54 | MK | Exactly that is why i add it some people like and the other not
| |
21:55 | MK | also that is why i added the note about VHDL built in functions style to point in the direction of underscore separated world
| |
21:55 | TofuLynx | Off for today! Goodnight!
| |
21:55 | TofuLynx | left the channel | |
21:57 | Bertl_oO | let's stick with snake_case for VHDL :)
| |
22:39 | Bertl_oO | off to bed now ... have a good one everyone!
| |
22:39 | Bertl_oO | changed nick to: Bertl_zZ
| |
22:41 | illwieckz | left the channel | |
22:49 | illwieckz | joined the channel |