| 00:22 | Xaxamiun | left the channel |
| 00:27 | Xaxamiun | joined the channel |
| 02:53 | Bertl_oO | off to bed now ... have a good one everyone!
|
| 02:53 | Bertl_oO | changed nick to: Bertl_zZ
|
| 06:57 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 08:28 | Xaxamiun | left the channel |
| 10:47 | BAndiT1983 | hi panintended, have commented on your latest commit, please check
|
| 11:18 | mumptai | joined the channel |
| 11:47 | Bertl_zZ | changed nick to: Bertl
|
| 11:47 | Bertl | morning folks!
|
| 11:49 | apurvanandan[m] | Good morning Bertl!
|
| 12:26 | Bertl | off for now ... bbl
|
| 12:26 | Bertl | changed nick to: Bertl_oO
|
| 13:38 | mumptai | left the channel |
| 13:41 | panintended | BAndiT1983 Yes, I got a notification. Thanks, I will reply later tonight.
|
| 13:43 | BAndiT1983 | looking forward to it
|
| 13:57 | mumptai | joined the channel |
| 15:23 | lexano | left the channel |
| 15:37 | lexano | joined the channel |
| 16:03 | lexano | left the channel |
| 16:49 | lexano | joined the channel |
| 17:01 | lexano | left the channel |
| 17:07 | megora | joined the channel |
| 17:12 | megora | left the channel |
| 17:57 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 18:54 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 19:31 | panintended | BAndiT1983: Hi. I've eplied to your comments. Let me know if you have more questions
|
| 19:32 | BAndiT1983 | hi panintended, seen at and just read your explanation about the strcpy()
|
| 19:32 | BAndiT1983 | is the length also stored? or is it purely relying on terminator there?
|
| 19:33 | panintended | In general how does it look? Is it along the lines of what you were expecting?
|
| 19:33 | panintended | no, it's not stored
|
| 19:34 | BAndiT1983 | looks not bad, wanted to do some tests, but had no time for it yet, maybe i can combine with current effort from metal_dent[m], as she is implementing a host app and the protocol there is similar to what will be used for cam<->remote communication
|
| 19:34 | BAndiT1983 | can the feature be tested with unit tests?
|
| 19:38 | panintended | I don't see why not. Do you guys use a framework like cppunit, or libcheck?
|
| 19:40 | BAndiT1983 | catch2, you can get the idea from FirmwareTest module
|
| 19:42 | panintended | oh, cool. Completely missed that
|
| 19:42 | panintended | I think I'll get some time on Tuesday to write tests for it
|
| 19:43 | BAndiT1983 | sounds good, just ping me if you need assistance there
|
| 19:43 | panintended | yeap
|
| 19:43 | panintended | thanks!
|
| 19:43 | BAndiT1983 | no problem
|
| 19:44 | lexano | joined the channel |
| 19:44 | BAndiT1983 | will try to get some close to real test soon, as it's still my plan to be able to communicate with the firmware in visualiser by using virtual serial connection
|
| 19:45 | panintended | by the way, what's the timeframe that you guys are aiming for regarding switching to the observer pattern?
|
| 19:46 | BAndiT1983 | as soon as it's stable and tested, we can start to use it
|
| 19:46 | panintended | ok
|
| 20:39 | panintended | BAndiT1983: I've pushed another commit to my fork in case you want to have a look. Nothing major, just cleanup and also implement some of your suggestions in your review.
|
| 20:40 | panintended | Also, I've added a second reply to your comment regarding the private and public sections of the Attribute class
|
| 20:40 | panintended | I thinks that's it for me folks. Off to bed, good night
|
| 21:38 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 22:13 | mumptai | left the channel |
| 23:40 | comradekingu | left the channel |
| 23:40 | comradekingu | joined the channel |