apertus° IRC logs

2020/05/21

Timezone: UTC

03:16

megora

joined the channel

03:21

megora

left the channel

03:40

aombk2

joined the channel

03:43

aombk

left the channel

06:24

Bertl

off to bed now ... have a good one everyone!

06:24

Bertl

changed nick to: Bertl_zZ

06:44

panintended

Hello people, good morning

06:45

futarisIRCcloud

left the channel

06:45

panintended

BAndiT1983: can you have another look at my fork? I made some changes for the button down events

06:46

panintended

and I also like your feedback on the way I did things (e.g. with organizing the buttons). There are still things to figure out (e.g. where to fit the knob press button down event)

06:47

panintended

take care, I'll catch you guys later today

07:10

Umori

left the channel

08:06

futarisIRCcloud

joined the channel

08:26

BAndiT1983|away

changed nick to: BAndiT1983

08:37

se6ast1an

good morning

08:37

se6ast1an

thanks panintended!

09:16

BAndiT1983

changed nick to: BAndiT1983|away

09:30

BAndiT1983|away

changed nick to: BAndiT1983

09:35

BAndiT1983

changed nick to: BAndiT1983|away

09:43

BAndiT1983|away

changed nick to: BAndiT1983

10:06

se6ast1an

claimed https://lab.apertus.org/T1202 and working on it right now

10:06

se6ast1an

will also created an updated knob graphics today

10:06

se6ast1an

is it an international holiday today or just in Austria?

10:07

metal_dent[m]

not a holiday here :/

10:08

se6ast1an

too bad!

10:08

BAndiT1983

it's in germany also a holiday, somew catholic or whatever church stuff

10:08

se6ast1an

how are things going metal_dent[m]?

10:09

se6ast1an

haha, BAndiT1983 you sound very religious indeed "some catholic or whatever church stuff" :)

10:10

metal_dent[m]

working on ImageButton, as you said i added "gap" as a member and tried to make "image_width + gap + text_width" centred in the rectangle

10:11

se6ast1an

great, what challenges are you facing with it?

10:11

se6ast1an

btw BAndiT1983 please take a look at panintendeds message/code - see above

10:11

BAndiT1983

am baptised but was never really into that stuff

10:11

metal_dent[m]

the image is properly drawing but something's not right with the text, trying to debug it

10:12

BAndiT1983

have seen the message already, but am just relaxing at the moment, so any development and related things will be done later

10:12

se6ast1an

sure, no rush!

10:12

se6ast1an

also when you have relaxed properly please take a look at https://github.com/apertus-open-source-cinema/AXIOM-Remote/pull/15 - is there anything left to be done or can it be merged?

10:13

se6ast1an

<metal_dent[m]> the image is properly drawing but something's not right with the text, trying to debug it <- can you share a screenshot? is the position not right or the drawing itself?

10:13

metal_dent[m]

position is not right

10:15

se6ast1an

how do you calculate positions currently?

10:15

se6ast1an

one potential pitfall I can think of is that you need to use TEXT_ALIGN_LEFT for the text instead of center now

10:19

BAndiT1983

if you would create an enum for the text position on the button, like i've suggested, then oyu would just switch between different text alignments according to the selected text position on the button

10:21

metal_dent[m]

as the image is on the left so it should start with +_width/2-total_width/2 (total_width is image+gap+text) and text from image_pos + gap ; i tried this but yeah maybe i need to change the alignment

10:22

BAndiT1983

why are such complex calculatiosn required?

10:22

metal_dent[m]

> if you would create an enum for the text position on the button, like i've suggested, then oyu would just switch between different text alignments according to the selected text position on the button

10:22

metal_dent[m]

also one enum for image position, so we can have all the combinations, as right now we only have image on left and text on right

10:22

BAndiT1983

*calculations

10:23

BAndiT1983

first i dislike the calculations which are doing too many things at once, as it's not recognizable what it should do

10:24

BAndiT1983

second thing, just calculate the overall width of image width + gap + text width and use it to center on the button

10:26

se6ast1an

I like drawing the dimensions to make up my mind about such layout placements, let me see if there is some online collaboration drawboard for this

10:26

BAndiT1983

https://aggie.io/u6b9tu6xg4

10:27

se6ast1an

perfect!

10:27

BAndiT1983

nice, looks to work good

10:30

se6ast1an

text writing is a bit cumbersome with the pencil :)

10:30

se6ast1an

but there is no text tool it seems...

10:30

BAndiT1983

yep, noticed that too instantly

10:30

se6ast1an

how is this

10:30

se6ast1an

https://app.sketchtogether.com/s/sketch/rbJWw.4.1/

10:30

BAndiT1983

they are targeting drawing mostly

10:32

BAndiT1983

great stuff! seen what i did there? ;)

10:33

se6ast1an

yes, realtime

10:33

se6ast1an

even while you move the icon

10:33

se6ast1an

very good

10:33

se6ast1an

metal_dent[m]: do you observe?

10:33

metal_dent[m]

yes yes, i'm watching

10:34

se6ast1an

great

10:37

BAndiT1983

it's much easier if you calculate the width of image + gap + text

10:38

BAndiT1983

this would be your X origin of the stuff, placing image according to it is simple, for text just to + image_width + gap_width

10:39

metal_dent[m]

> this would be your X origin of the stuff, placing image according to it is simple, for text just to + image_width + gap_width

10:39

metal_dent[m]

yes, this is what i did

10:39

BAndiT1983

where?

10:39

metal_dent[m]

in my code

10:39

BAndiT1983

please paste the link to it, if it's uploaded

10:39

metal_dent[m]

painter->DrawText(_x + imagePosX + _image->Width + _gap, _y + textPosY, _label, _currentTextColor, TextAlign::TEXT_ALIGN_CENTER,

10:39

metal_dent[m]

strlen(_label));

10:41

BAndiT1983

please avoid placing that many calculations in the method call, calculate them before that or even in another method, like Setup(), when you call the constructor, it would reduce the need to calculate things over and over

10:42

BAndiT1983

also when you have proper variables which hold the values, it's much more easier to grasp the logic of the code

10:42

metal_dent[m]

yes, i was gonna do that after it's confirmed that this works or not

10:44

BAndiT1983

it's important to learn to do it right from the start, am also doing quick checks by adjusting inline, but usually moving longer calculations to appropriate variables, to not loose the track of logic in code

10:44

metal_dent[m]

alright, will keep that in mind!

10:44

BAndiT1983

it's easier to read textPosX than a bunch of + calculations of different vars

10:45

BAndiT1983

very good

10:46

se6ast1an

the drawing should be complete now and I hope the way we did it with the colors also very clear and understandable

10:46

BAndiT1983

looks good so far

10:47

BAndiT1983

we need such software (maybe a bit more advanced for technical drawing) somewhere on own servers

10:49

se6ast1an

would be cool

10:50

metal_dent[m]

after aligning on left i think it works now!

10:50

se6ast1an

great

10:52

metal_dent[m]

https://pasteboard.co/J9nAO4t.png

10:53

BAndiT1983

very good

10:54

BAndiT1983

se6ast1an: sent you a link for a quick test of draw.io which i've shared through my gdrive

10:54

BAndiT1983

using this software also at work, but in confluence etc.

10:54

metal_dent[m]

okay, I'll clean up the code and ccommit

11:05

se6ast1an

BAndiT1983: also looks good but requires google authorization for all participants no?

11:07

BAndiT1983

as we have it for gsoc, so maybe some alternative, don't remember how it is with self-hosting

11:07

BAndiT1983

ah, it's open-source https://github.com/jgraph/drawio

11:07

se6ast1an

nice

11:21

se6ast1an

live/set toggle button added

11:21

se6ast1an

https://paste.pics/716d100215759ffddddd3c2520796d2a

11:25

BAndiT1983

nice! but looks a bit shifted, did you center it? would do for both texts

100

11:30

joined the channel

101

11:30

left the channel

102

11:31

se6ast1an

sure, it can still be a bit fine tuned

103

11:31

se6ast1an

replaced knob image

104

11:32

se6ast1an

I noticed that it has exactly as many indents as rotation options so it appears to no be rotating...

105

11:32

se6ast1an

will try to fix that as well

106

11:33

BAndiT1983

could you please adjust the SVG file, as it's the main file

107

11:33

BAndiT1983

you could also easily reduce/increase the number of indents there

108

11:35

se6ast1an

not really as I have no experience with svg/vector graphics design

109

11:36

BAndiT1983

it's much easier than adjusting the PNG

110

11:36

BAndiT1983

inkscape is great for it

111

11:40

BAndiT1983

as you know how to use CAD and such things, there should be no problem for you with inkscape at all, almost same stuff, like creating the sketches for CAD

112

11:41

se6ast1an

will check

113

11:55

se6ast1an

time for lunch

114

11:55

BAndiT1983

have a nice meal

115

11:56

metal_dent[m]

bon appetit!

116

11:58

BAndiT1983

metal_dent[m]: time to learn Austrian: an Guaden

117

12:01

metal_dent[m]

aren't you German?

118

12:03

BAndiT1983

not german at all, it's my third language as i live in germany for 25 years, but german and austrian are almost the same, so we can speak to each other without a problem

119

12:04

BAndiT1983

austrians will slap me for that, but austrian is like a dialect of german, although german has also came a long way till it has formed like nowadays

120

12:06

metal_dent[m]

ouuu, danke for this information..!

121

12:08

se6ast1an

yes, just because we speak the same language doesnt mean we understand each other :D

122

12:10

BAndiT1983

i understand bootloader, you the firmware and Bertl is the transcendent medium which understands it all ;)

123

12:48

se6ast1an

back

124

12:48

se6ast1an

regarding https://lab.apertus.org/T1202

125

12:48

se6ast1an

I am now thinking if it wouldnt be clearer if the button just said "Live" and has a checkbox next to it

126

12:48

se6ast1an

enable/disable

127

12:50

BAndiT1983

sounds also good, do we have the checkbox already?

128

12:51

se6ast1an

no: https://lab.apertus.org/T1193

129

12:55

BAndiT1983

then T1193 has to be done first, everything else is depending on that

130

12:55

BAndiT1983

i mean T1202 is depending on it

131

12:59

se6ast1an

yes, can use anothe icon or placeholder in the meantime though

132

12:59

se6ast1an

metal_dent[m]: what would you like to claim when you are done with your current tasks?

133

13:18

metal_dent[m]

Sorry I took a nap ':D, yes sure I'll work on it!

134

13:26

se6ast1an

great, please claim

135

13:41

se6ast1an

learned a bit of inkscape and updated the knob design

136

13:42

BAndiT1983

regarding PR15, added a comment as sample.h needs small adjustments

137

13:48

comradekingu

left the channel

138

14:14

comradekingu

joined the channel

139

14:26

BAndiT1983

metal_dent[m]: have you pushed again? also please no force-push, as i see that you've done it in the logs, this can break the code hard and then somebody has to clean the mess up

140

14:26

BAndiT1983

it's important to learn how to solve merge conflicts, they are reported for a reason by git

141

14:27

metal_dent[m]

no, I haven't pushed

142

14:28

BAndiT1983

as you've marked as resolved, so i've thought that i can review again