#apertus IRC Channel Logs

off to bed now ... have a good one everyone!

Hello people, good morning

BAndiT1983: can you have another look at my fork? I made some changes for the button down events

take care, I'll catch you guys later today

good morning

claimed https://lab.apertus.org/T1202 and working on it right now

is it an international holiday today or just in Austria?

too bad!

how are things going metal_dent[m]?

working on ImageButton, as you said i added "gap" as a member and tried to make "image_width + gap + text_width" centred in the rectangle

btw BAndiT1983 please take a look at panintendeds message/code - see above

the image is properly drawing but something's not right with the text, trying to debug it

sure, no rush!

<metal_dent[m]> the image is properly drawing but something's not right with the text, trying to debug it <- can you share a screenshot? is the position not right or the drawing itself?

how do you calculate positions currently?

if you would create an enum for the text position on the button, like i've suggested, then oyu would just switch between different text alignments according to the selected text position on the button

why are such complex calculatiosn required?

also one enum for image position, so we can have all the combinations, as right now we only have image on left and text on right

first i dislike the calculations which are doing too many things at once, as it's not recognizable what it should do

I like drawing the dimensions to make up my mind about such layout placements, let me see if there is some online collaboration drawboard for this

perfect!

text writing is a bit cumbersome with the pencil :)

yep, noticed that too instantly

https://app.sketchtogether.com/s/sketch/rbJWw.4.1/

great stuff! seen what i did there? ;)

even while you move the icon

metal_dent[m]: do you observe?

great

this would be your X origin of the stuff, placing image according to it is simple, for text just to + image_width + gap_width

yes, this is what i did

in my code

painter->DrawText(_x + imagePosX + _image->Width + _gap, _y + textPosY, _label, _currentTextColor, TextAlign::TEXT_ALIGN_CENTER,

please avoid placing that many calculations in the method call, calculate them before that or even in another method, like Setup(), when you call the constructor, it would reduce the need to calculate things over and over

yes, i was gonna do that after it's confirmed that this works or not

alright, will keep that in mind!

very good

looks good so far

would be cool

great

very good

using this software also at work, but in confluence etc.

BAndiT1983: also looks good but requires google authorization for all participants no?

ah, it's open-source https://github.com/jgraph/drawio

live/set toggle button added

nice! but looks a bit shifted, did you center it? would do for both texts

replaced knob image

will try to fix that as well

you could also easily reduce/increase the number of indents there

it's much easier than adjusting the PNG

as you know how to use CAD and such things, there should be no problem for you with inkscape at all, almost same stuff, like creating the sketches for CAD

time for lunch

bon appetit!

aren't you German?

austrians will slap me for that, but austrian is like a dialect of german, although german has also came a long way till it has formed like nowadays

yes, just because we speak the same language doesnt mean we understand each other :D

back

I am now thinking if it wouldnt be clearer if the button just said "Live" and has a checkbox next to it

sounds also good, do we have the checkbox already?

then T1193 has to be done first, everything else is depending on that

yes, can use anothe icon or placeholder in the meantime though

Sorry I took a nap ':D, yes sure I'll work on it!

learned a bit of inkscape and updated the knob design

metal_dent[m]: have you pushed again? also please no force-push, as i see that you've done it in the logs, this can break the code hard and then somebody has to clean the mess up

no, I haven't pushed

ohh, no wait, other things are done, just the instance creation may require some changes in makefile

morning folks!

https://lab.apertus.org/T1202#17211 pushed

true

Hi guys