#apertus IRC Channel Logs

off to bed now ... have a good one everyone!

I was trying to load sample MLV to opencine by making changes to presenter - > https://github.com/apertus-open-source-cinema/opencine/blob/master/Source/ProcessingTest/Presenters/ProcessingPresenter.cpp

but it failed by giving this error messages . https://pastebin.com/g6izYEc0

FATAL CRASH HANDLED; Application has crashed due to [SIGSEGV] signal , - > is it related to size

as i said, there is not much info, but look at the line before, it relates to extracting

It looks like the error is in Bayerframeprocess

When removing frameProcess object , it compiles error free

line*

I was tring to find the source

the source is in the bayer pre-processor

yes , I can see this need

set a breakpoint there or wait till it crashes in debugger, inspect the stack trace and related values in the watch window

https://www.magiclantern.fm/forum/index.php?topic=11899.0 from here

will do it also, which file do you use exactly

http://dl.phreekz.de/raw2cdng/ML_Samples/M11-1526.VB.mlv , This one

I have made changes for that

for MLV or DNG

you can use it, to select right format, e.g. by creating an array of formats in the order of file filters

am checking that only

it's (_currentFilePath)

https://github.com/apertus-open-source-cinema/opencine/blob/master/Source/ProcessingTest/Presenters/ProcessingPresenter.cpp ,

instead of path comparision

Dev_, jsut be aware of, that QFileInfo data is only partially reliable, as the extension will contain several parts, if there are more dots in the file name

But right now std::string extension = _currentFilePath.substr(_currentFilePath.find_last_of(".") + 1);

I am doing this to check the file extension

*what i

std::string extension = _currentFilePath.substr(_currentFilePath.find_last_of(".") + 1);

to avoid the need to check all possible variants, as linux is picky there

very good

on my machine the crash occurs in the downscaler on line 52

have this quick and dirty solution for now ->

std::string extension = _currentFilePath.substr(_currentFilePath.find_last_of(".") + 1);

if(extension == "mlv")

format = FileFormat::MLV;

OC_LOG_INFO("Loading image");

yes i am using this right now for loading MLV

great, then you are on the good track there

formatting

This is giving error

name of file , BayerDownscaler ?

BayerFrameDownscaler.cpp

but we have to raise the quality and add more unit tests, split methods, remove junk code

I understand , I will try to look more

please create a pull request, if you have completed bug fixes etc.

At present , I have just inculded loading for DNG and MLV files , is it okay to push it into main Branch

What about looking at the header of a file instead of its extension to determine the file format?

and it's more difficult to accomplish in smart way, without introducing many side paths

please add MapPatternToData(); at the end of SetData(), there are 2 of them, but one lacks this method

vup2, but the idea is rather nice to add some straight forward checker for the starting bytes of the file, in our case it's rather simple as TIFF and DNG start with certain characters

yep

vup2, thinking of adding specialized method to the loaders for sanity check of the file format, what do you think about it? it would loop through the loaders and try to find correct one

yes , its working now

if yes, then it's seems like byte swapping is missing

yes

exactly, but your file seems to be different

https://lab.apertus.org/T772 , I thought , it worked fine once

yep, great

(also i think the performance aspect is negligible, as the debayering and other processing will probably take the most time anyways)

for(int i = 0; i < size; i += 2)

uint8_t temp = sourceData[i];

sourceData[i + 1] = temp;

before ->

std::swap ...

yes vup2

had a solution with shifts before, as swap performance wasn't benchmarked by me before

one thing which is still not added for MLV, the check for swapping, usually it's required, as the cannon uses ARM, but it could change at some point

https://pasteboard.co/Ib069Rb.png

what about lower part?

also yuick and dirty solution, but this should work -> for(unsigned int i = 0; i < size - 2; i += 2)

std::swap(sourceData[i], sourceData[i + 1]);

*quick

yes i am seeing

Good Morning Bertl

Thanks for help !

off to bed now ... have a good one everyone!

BAndiT1983: I have created another pull request to dev branch , please check

Dev_, seen it, will check tomorrow, it's rather late here