| 23:02 | illwieckz | left the channel |
| 23:05 | illwieckz | joined the channel |
| 03:29 | Bertl_oO | off to bed now ... have a good one!
|
| 03:29 | Bertl_oO | changed nick to: Bertl_zZ
|
| 05:43 | niemand | joined the channel |
| 06:24 | pusle | joined the channel |
| 06:38 | rton | joined the channel |
| 07:09 | niemand | left the channel |
| 07:30 | rahul | left the channel |
| 07:30 | rahul___ | changed nick to: rahul
|
| 07:31 | rahul_ | joined the channel |
| 08:29 | hozer | left the channel |
| 08:35 | se6astian|away | changed nick to: se6astian
|
| 08:36 | se6astian | https://opensource.googleblog.com/2018/03/coding-your-way-into-cinemas.html
|
| 08:36 | se6astian | changed nick to: se6astian|away
|
| 08:44 | sebix | joined the channel |
| 08:44 | sebix | left the channel |
| 08:44 | sebix | joined the channel |
| 09:57 | Bertl_zZ | changed nick to: Bertl
|
| 09:57 | Bertl | morning folks!
|
| 09:57 | Bertl | se6astian: old, mithro posted it yesterday! :)
|
| 10:27 | TofuLynx_ | joined the channel |
| 11:55 | TofuLynx_ | left the channel |
| 12:07 | madonius | joined the channel |
| 12:40 | TofuLynx_ | joined the channel |
| 12:54 | TofuLynx_ | left the channel |
| 12:54 | TofuLynx_ | joined the channel |
| 12:59 | TofuLynx_ | left the channel |
| 13:12 | TofuLynx_ | joined the channel |
| 13:16 | rton93 | joined the channel |
| 13:16 | nmdis1999 | joined the channel |
| 13:17 | nmdis1999 | interesting article :) I didn't knew initially three student started last year. What were the other two projects?
|
| 13:19 | Bertl | https://www.apertus.org/apertus-google-summer-of-code-article-may-2017
|
| 13:19 | rton | left the channel |
| 13:24 | nmdis1999 | Thanks :)
|
| 13:33 | Bertl | np
|
| 13:39 | nmdis1999 | Bertl, after final review (I am almost done adding the things that you mentioned) should I submit the proposal on gsoc apertus platform?
|
| 13:56 | nmdis1999 | left the channel |
| 14:45 | TofuLynx_ | left the channel |
| 14:54 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 15:51 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 15:55 | supragya | joined the channel |
| 16:02 | supragya | left the channel |
| 16:06 | pusle | left the channel |
| 16:13 | supragya | joined the channel |
| 16:18 | supragya | left the channel |
| 17:25 | TofuLynx | joined the channel |
| 17:32 | supragya | joined the channel |
| 17:34 | TofuLynx | hey supragya !
|
| 17:34 | supragya | hey TofuLynx
|
| 17:36 | supragya | how's it with the downscaler
|
| 17:36 | TofuLynx | Today i will be working on it
|
| 17:36 | TofuLynx | I have **FINALLY** the time
|
| 17:36 | supragya | nice !
|
| 17:36 | TofuLynx | i will study your suggestion
|
| 17:36 | supragya | I will get some time... maybe after this week... will begin FrameServer prototype work too!
|
| 17:37 | TofuLynx | That's great!
|
| 17:38 | TofuLynx | you said that suggestion yesterday or sunday?
|
| 17:38 | TofuLynx | nvm just saw it
|
| 17:38 | TofuLynx | it was yesterday
|
| 17:44 | sebix | left the channel |
| 17:54 | TofuLynx | supragya
|
| 17:54 | TofuLynx | I can't link your suggestion to my error
|
| 17:54 | TofuLynx | as blue channels are affected, it doesnt involve any arithmetics
|
| 17:55 | supragya | ? doesn't involve arithmetic?
|
| 17:55 | supragya | you would be extracting it right?
|
| 17:55 | TofuLynx | nope, it's an extractor
|
| 17:55 | TofuLynx | so it extracts from already processed data
|
| 17:58 | supragya | i haven't really looked at the code...
|
| 18:01 | TofuLynx | another curious thing is that the artifact is exactly on the last row at exactly the middle of the image
|
| 18:01 | supragya | as I suggested last time, use a dump and see if the artifact is UI related or actually image related
|
| 18:02 | TofuLynx | a dump?
|
| 18:02 | supragya | see logs
|
| 18:02 | supragya | yesterday OC_INFO_DUMP
|
| 18:24 | MK | joined the channel |
| 18:26 | TofuLynx_ | joined the channel |
| 18:29 | se6astian|away | changed nick to: se6astian
|
| 18:34 | MK | left the channel |
| 18:34 | MK | joined the channel |
| 19:00 | supragya | Bertl, I have incorporated your suggestions on the C++ challenge. A final look maybe?
|
| 19:01 | Bertl | sure
|
| 19:03 | Bertl | it looks quite nicely formatted, here a few hints for the final touch:
|
| 19:04 | Bertl | - put an empty line after local variable declarations to separate the variables from the code
|
| 19:04 | Bertl | - add a break to the default: branch
|
| 19:05 | TofuLynx_ | left the channel |
| 19:05 | Bertl | - make sure there are spaces after // :)
|
| 19:07 | supragya | done: https://github.com/supragya/PiNG12RAW/commit/5ff53b783326fcd01e74b472284944a331e823d4
|
| 19:09 | supragya | thank you!
|
| 19:09 | supragya | left the channel |
| 19:12 | Bertl | from the funtional side, error handling could be improved I guess
|
| 19:13 | MK_18 | joined the channel |
| 19:14 | supragya | joined the channel |
| 19:15 | supragya | Bertl, are you talking about the constructor? Debayer::DebayerContainer::DebayerContainer()?
|
| 19:16 | Bertl | try what happens when your input file cannot be opened/found
|
| 19:16 | supragya | oh... I am sorry
|
| 19:16 | supragya | I still read
|
| 19:20 | supragya | this should do I guess
|
| 19:22 | Bertl | the famous 'error 1' ...
|
| 19:22 | supragya | :)
|
| 19:22 | Bertl | now check what happens when your file is too small
|
| 19:23 | supragya | each should have a different error code I guess?
|
| 19:24 | Bertl | well, there are many ways to handle errors properly, I'm just saying
|
| 19:25 | supragya | will look into them... and make a better commit a bit later!
|
| 19:26 | MK | Bertl, Hi I finished the task can you please take a look and tell me what do you think? https://github.com/Mahmoud-Khaled-Nasr/PWM-chip-using-I2C-interface.git
|
| 19:27 | MK | Bertl, By the way i started working on the Style wiki I hope i could finish it soon :)
|
| 19:27 | MK_18 | left the channel |
| 19:29 | Bertl | MK: will do shortly ... btw, you might want to link it under 'Code for review' on the T871 page
|
| 19:30 | MK | Bertl, ok I will do it right away
|
| 19:32 | Bertl | okay, here the first comments (and probably additions to the style guide):
|
| 19:32 | Bertl | looking at the I2C interface.vhd I see ...
|
| 19:33 | Bertl | - spaces in filenames are not a good choice (similar to '/' and '\' or special characters)
|
| 19:33 | Bertl | - the file is missing a copyright line and some license information
|
| 19:34 | Bertl | - there is an 80 column limit (more 76 columns)
|
| 19:35 | Bertl | you should keep your lines below that, using 4 character indentation/tabs is okay as long as you make sure that the resulting ASCII file is properly indented
|
| 19:35 | Bertl | when lines become too long, it is a good hint that you might want to break things down into smaller chunks
|
| 19:37 | Bertl | - make use of rising_edge() and falling_edge() because it dramatically improves readability
|
| 19:38 | Bertl | - don't use upper case for variables or signals, reserve it for generics and constants
|
| 19:38 | Bertl | (I'm not religious on that because VHDL is case agnostic, but I think it is a good idea)
|
| 19:41 | Bertl | otherwise it doesn't look bad
|
| 19:42 | supragya | I don't know why these things are marked "Needs Triage": https://lab.apertus.org/T819 ?
|
| 19:43 | Bertl | probably because Walter is involved :)
|
| 19:45 | supragya | sebastian gave the correct image for it :) [upvoted]
|
| 19:46 | Bertl | MK: okay, I guess you have a few pointers for the next interation.
|
| 19:46 | Bertl | off for now ... bbl
|
| 19:46 | Bertl | changed nick to: Bertl_oO
|
| 19:48 | MK | Bertl_oO, Thanks very much it will be ready very soon but i can't seem to find how to add my code for review
|
| 19:49 | supragya2 | joined the channel |
| 19:50 | supragya | left the channel |
| 19:50 | supragya2 | MK, I guess we don't have edit privileges.
|
| 19:51 | supragya2 | left the channel |
| 20:07 | MK | left the channel |
| 20:21 | TofuLynx | supragya is right
|
| 20:22 | TofuLynx | you have to request someone to put it :)
|
| 20:27 | slikdigit | joined the channel |
| 20:52 | Bertl_oO | it ah, right, we locked that one down, you should now be able to edit it
|
| 21:24 | se6astian | off to bed
|
| 21:24 | se6astian | good night
|
| 21:24 | TofuLynx | bye bye!
|
| 21:24 | se6astian | changed nick to: se6astian|away
|
| 21:59 | TofuLynx | Bertl_oO , can you please review my code on github again? :)
|
| 22:39 | Bertl_oO | will do tomorrow ... off to bed now ... have a good one everyone!
|
| 22:39 | Bertl_oO | changed nick to: Bertl_zZ
|