Current Server Time: 12:51 (Central Europe)

#apertus IRC Channel Logs

2018/03/20

Timezone: UTC


00:02
illwieckz
left the channel
00:05
illwieckz
joined the channel
04:29
Bertl_oO
off to bed now ... have a good one!
04:29
Bertl_oO
changed nick to: Bertl_zZ
06:43
niemand
joined the channel
07:24
pusle
joined the channel
07:38
rton
joined the channel
08:09
niemand
left the channel
08:30
rahul
left the channel
08:30
rahul___
changed nick to: rahul
08:31
rahul_
joined the channel
09:29
hozer
left the channel
09:35
se6astian|away
changed nick to: se6astian
09:36
se6astian
https://opensource.googleblog.com/2018/03/coding-your-way-into-cinemas.html
09:36
se6astian
changed nick to: se6astian|away
09:44
sebix
joined the channel
09:44
sebix
left the channel
09:44
sebix
joined the channel
10:57
Bertl_zZ
changed nick to: Bertl
10:57
Bertl
morning folks!
10:57
Bertl
se6astian: old, mithro posted it yesterday! :)
11:27
TofuLynx_
joined the channel
12:55
TofuLynx_
left the channel
13:07
madonius
joined the channel
13:40
TofuLynx_
joined the channel
13:54
TofuLynx_
left the channel
13:54
TofuLynx_
joined the channel
13:59
TofuLynx_
left the channel
14:12
TofuLynx_
joined the channel
14:16
rton93
joined the channel
14:16
nmdis1999
joined the channel
14:17
nmdis1999
interesting article :) I didn't knew initially three student started last year. What were the other two projects?
14:19
Bertl
https://www.apertus.org/apertus-google-summer-of-code-article-may-2017
14:19
rton
left the channel
14:24
nmdis1999
Thanks :)
14:33
Bertl
np
14:39
nmdis1999
Bertl, after final review (I am almost done adding the things that you mentioned) should I submit the proposal on gsoc apertus platform?
14:56
nmdis1999
left the channel
15:45
TofuLynx_
left the channel
15:54
BAndiT1983|away
changed nick to: BAndiT1983
16:51
BAndiT1983
changed nick to: BAndiT1983|away
16:55
supragya
joined the channel
17:02
supragya
left the channel
17:06
pusle
left the channel
17:13
supragya
joined the channel
17:18
supragya
left the channel
18:25
TofuLynx
joined the channel
18:32
supragya
joined the channel
18:34
TofuLynx
hey supragya !
18:34
supragya
hey TofuLynx
18:36
supragya
how's it with the downscaler
18:36
TofuLynx
Today i will be working on it
18:36
TofuLynx
I have **FINALLY** the time
18:36
supragya
nice !
18:36
TofuLynx
i will study your suggestion
18:36
supragya
I will get some time... maybe after this week... will begin FrameServer prototype work too!
18:37
TofuLynx
That's great!
18:38
TofuLynx
you said that suggestion yesterday or sunday?
18:38
TofuLynx
nvm just saw it
18:38
TofuLynx
it was yesterday
18:44
sebix
left the channel
18:54
TofuLynx
supragya
18:54
TofuLynx
I can't link your suggestion to my error
18:54
TofuLynx
as blue channels are affected, it doesnt involve any arithmetics
18:55
supragya
? doesn't involve arithmetic?
18:55
supragya
you would be extracting it right?
18:55
TofuLynx
nope, it's an extractor
18:55
TofuLynx
so it extracts from already processed data
18:58
supragya
i haven't really looked at the code...
19:01
TofuLynx
another curious thing is that the artifact is exactly on the last row at exactly the middle of the image
19:01
supragya
as I suggested last time, use a dump and see if the artifact is UI related or actually image related
19:02
TofuLynx
a dump?
19:02
supragya
see logs
19:02
supragya
yesterday OC_INFO_DUMP
19:24
MK
joined the channel
19:26
TofuLynx_
joined the channel
19:29
se6astian|away
changed nick to: se6astian
19:34
MK
left the channel
19:34
MK
joined the channel
20:00
supragya
Bertl, I have incorporated your suggestions on the C++ challenge. A final look maybe?
20:01
Bertl
sure
20:03
Bertl
it looks quite nicely formatted, here a few hints for the final touch:
20:04
Bertl
- put an empty line after local variable declarations to separate the variables from the code
20:04
Bertl
- add a break to the default: branch
20:05
TofuLynx_
left the channel
20:05
Bertl
- make sure there are spaces after // :)
20:07
supragya
done: https://github.com/supragya/PiNG12RAW/commit/5ff53b783326fcd01e74b472284944a331e823d4
20:09
supragya
thank you!
20:09
supragya
left the channel
20:12
Bertl
from the funtional side, error handling could be improved I guess
20:13
MK_18
joined the channel
20:14
supragya
joined the channel
20:15
supragya
Bertl, are you talking about the constructor? Debayer::DebayerContainer::DebayerContainer()?
20:16
Bertl
try what happens when your input file cannot be opened/found
20:16
supragya
oh... I am sorry
20:16
supragya
I still read
20:20
supragya
this should do I guess
20:22
Bertl
the famous 'error 1' ...
20:22
supragya
:)
20:22
Bertl
now check what happens when your file is too small
20:23
supragya
each should have a different error code I guess?
20:24
Bertl
well, there are many ways to handle errors properly, I'm just saying
20:25
supragya
will look into them... and make a better commit a bit later!
20:26
MK
Bertl, Hi I finished the task can you please take a look and tell me what do you think? https://github.com/Mahmoud-Khaled-Nasr/PWM-chip-using-I2C-interface.git
20:27
MK
Bertl, By the way i started working on the Style wiki I hope i could finish it soon :)
20:27
MK_18
left the channel
20:29
Bertl
MK: will do shortly ... btw, you might want to link it under 'Code for review' on the T871 page
20:30
MK
Bertl, ok I will do it right away
20:32
Bertl
okay, here the first comments (and probably additions to the style guide):
20:32
Bertl
looking at the I2C interface.vhd I see ...
20:33
Bertl
- spaces in filenames are not a good choice (similar to '/' and '\' or special characters)
20:33
Bertl
- the file is missing a copyright line and some license information
20:34
Bertl
- there is an 80 column limit (more 76 columns)
20:35
Bertl
you should keep your lines below that, using 4 character indentation/tabs is okay as long as you make sure that the resulting ASCII file is properly indented
20:35
Bertl
when lines become too long, it is a good hint that you might want to break things down into smaller chunks
20:37
Bertl
- make use of rising_edge() and falling_edge() because it dramatically improves readability
20:38
Bertl
- don't use upper case for variables or signals, reserve it for generics and constants
20:38
Bertl
(I'm not religious on that because VHDL is case agnostic, but I think it is a good idea)
20:41
Bertl
otherwise it doesn't look bad
20:42
supragya
I don't know why these things are marked "Needs Triage": https://lab.apertus.org/T819 ?
20:43
Bertl
probably because Walter is involved :)
20:45
supragya
sebastian gave the correct image for it :) [upvoted]
20:46
Bertl
MK: okay, I guess you have a few pointers for the next interation.
20:46
Bertl
off for now ... bbl
20:46
Bertl
changed nick to: Bertl_oO
20:48
MK
Bertl_oO, Thanks very much it will be ready very soon but i can't seem to find how to add my code for review
20:49
supragya2
joined the channel
20:50
supragya
left the channel
20:50
supragya2
MK, I guess we don't have edit privileges.
20:51
supragya2
left the channel
21:07
MK
left the channel
21:21
TofuLynx
supragya is right
21:22
TofuLynx
you have to request someone to put it :)
21:27
slikdigit
joined the channel
21:52
Bertl_oO
it ah, right, we locked that one down, you should now be able to edit it
22:24
se6astian
off to bed
22:24
se6astian
good night
22:24
TofuLynx
bye bye!
22:24
se6astian
changed nick to: se6astian|away
22:59
TofuLynx
Bertl_oO , can you please review my code on github again? :)
23:39
Bertl_oO
will do tomorrow ... off to bed now ... have a good one everyone!
23:39
Bertl_oO
changed nick to: Bertl_zZ