#apertus IRC Channel Logs

morning folks!

Hi I have completed T884 Task 1

root@pratyush-HP-Laptop-15g-dr0xxx:/home/pratyush/Desktop/kc-final/kc# ./chrdev_test chrdevfile chrdev openedwrote 15 bytes into file chrdevdata written are: 50 72 61 74 79 75 73 68 20 48 61 72 73 48 00 file chrdev reopenedread 15 bytes from file chrdevdata read are: 50 72 61 74 79 75 73 68 20 48 61 72 73 48 00 The String Read is:Pratyush

I will be sharing the code :)

please do so and use a pastebin in the future :)

<script src="https://pastebin.com/embed_js/NrqrBHAS"></script>

btw, this is the simplest and most effective link:

pratyush: :)

Hi Bertl, I submitted a draft proposal for review

will check shortly

Here is a test run: https://pastebin.com/FGs1CNtH

How should I share code with you?

then send me a link via e-mail, private message or simply paste it here ... whatever you prefer

Bertl: Here is the code: https://github.com/Swaraj1998/apertus-kernel-challenge

bluez_[m]: it's rather old practice to put variables at the top of the function, usually they should be placed where they are used

it's not used until len = sprintf(buf, "checksum: %ld\n", checksum);, so you can also write int len = ...

BAndiT1983: ohh, ok got it! Actually I was in doubt weather that is allowed in the version of C that linux kernel uses...

it's up to Bertl to approve stuff, just giving hints of what i see and usually expect

BAndiT1983: also, can i initialize the loop counter "i" in the for loop, iirc its a feature of c99 but I dont koow if it is allowed in linux kernel

just try what happens when you do it

Bertl: I have shared code via email

Bertl: Actually I was in doubt weather its according to linux kernel style or not... will check again

also variables go to the top of a function/block, as the kernel doesn't use C99

Bertl: Thanks! I did follow that, but missed a few things I guess, but nevertheless it was correct

e.g. separate variables from code with an empty line

Bertl: what about initialization in the for loop? Can we do that in kernel?

i did use 8 spaces as suggested

<Bertl "e.g. separate variables from cod"> yes! will do that

Should I start with ioctl?

did you test it?

what issues did you find?

(the name is probably a good hint :)

Hello Bertl

I implemented the bitslip part too but i am a bit confused how to train my model in such a way that it takes testpattern as input when the data is under training and takes user input when the data is trained.

preetimenghwani[: you are talking about a testbench?

bluez_[m]: be aware that 'normal' C types like 'unsigned int' may have different sizes :)

why do you allocate the buffer on the stack?

is it available at all there?

how did reading back the data go in your tests?

check the link from Bertl, seen it there

<BAndiT1983 "check the link from Bertl, seen "> yeah found it!

In reply to Bertl

bluez_[m]: also check for any warning when you compile your code against the kernel

the smarter way is to have a signal which you want in your hardware design anyway

> bluez_: also check for any warning when you compile your code against the kernel

bluez_[m]: have you cranked up the compiler flags for more inspections?

> bluez_: have you cranked up the compiler flags for more inspections?

pratyush: you go by the pseudonym Rodolfo Giometti ?

Bertl:NO

nah, was just wondering about the MODULE_AUTHOR entry in the code :)

for me, basically nothing changed :)

Bertl : Shall I start to work on a proposal

Bertl : What improvements I need to make

so my suggestion would be to go through 'your' code line by line and make sure you know what it does and that it is really required

Bertl : sure

maybe discuss your solution with other potential applicants here to identify potential problems and get some ideas ...

Bertl : I will make the code more compact

off for now ... bbl

https://www.apertus.org/axiom-team-talk-15-3-packaging--axiom-micro-article-march-2020

Bertl: Hey! I have made appropriate changes, can you review once? Here's the link again: https://github.com/Swaraj1998/apertus-kernel-challenge

bluez_[m]: will check shortly ... but unused variables should be removed.

https://stackoverflow.com/questions/7090998/portable-unused-parameter-macro-used-on-function-signature-for-c-and-c

Sorry I meant to say unused parameters... from api functions

Is there an already defined macro in headers or I have to define those? I guess its better if its pre existing, I'll try it. Thanks!

i.e. unused parameters are probably a good indication that you are doing something wrong

of to bed

> i.e. unused parameters are probably a good indication that you are doing something wrong

Good night