Current Server Time: 04:13 (Central Europe)

#apertus IRC Channel Logs

2020/05/10

Timezone: UTC


01:19
intracube
left the channel
01:31
intracube
joined the channel
03:38
Bertl_oO
off to bed now ... have a good one everyone!
03:38
Bertl_oO
changed nick to: Bertl_zZ
06:39
BAndiT1983|away
changed nick to: BAndiT1983
07:28
metal_dent[m]
Hi, morning!
07:28
metal_dent[m]
this is the text image -> https://pasteboard.co/J7GU8pd.png
07:29
metal_dent[m]
now I'll do the header files conversion which will be same as last time, right?
07:31
BAndiT1983
hi
07:31
BAndiT1983
yes
07:32
metal_dent[m]
done!
07:35
metal_dent[m]
it's looking better than the last time -> https://pasteboard.co/J7GXmEf.png
07:37
BAndiT1983
yep
07:37
BAndiT1983
but we still need to do adjustments, i know that "a" in apertus has slight bow down, but it introduces more jagged lines and should be straightened out
07:37
metal_dent[m]
> any progress with makefile yet?
07:37
metal_dent[m]
I'll do that now, first I wanted to do the process on one image file
07:38
BAndiT1983
also "s"
07:38
BAndiT1983
ok
09:15
panintended
joined the channel
09:18
panintended
Hi all
09:19
BAndiT1983
hi
09:19
BAndiT1983
how is it going?
09:22
panintended
Not bad, the weather is nice today :P
09:22
panintended
I'm having a fresh look at T1184 (I stashed all of my changes till now)
09:22
panintended
yourself?
09:28
BAndiT1983
weather is getting better, was rainy
09:28
BAndiT1983
and, what are your conclusions so far? ;)
10:13
panintended
well, the "knob press inner circle area" approach does not seem that attractive anymore. It was too finnicky
10:13
panintended
now I'm looking into the flags once again
10:15
panintended
what I figured out was that when you push a flag, it's effect is applicable to *past* (as far as the imgui loop flow is concerned) GUI items -- not the ones that come later on
10:16
BAndiT1983
yep
10:16
panintended
wait, did I say that right?
10:16
BAndiT1983
have you checked my question yesterday?
10:16
panintended
you mean the 942 issue on dear imgui?
10:16
panintended
let me check the logs
10:17
BAndiT1983
no, the other one, about drawing button in the center of the knob and check the event, if it gets it first, before the knob
10:17
BAndiT1983
or to be precise the invisible button beneath it
10:17
panintended
panintended: what happens if you stack another button on top of the knob, in the center? is the click still affecting the knob?
10:17
panintended
this one?
10:18
BAndiT1983
regarding your question, of course you're right, as the flags are for the last object, it's a stack or so
10:18
BAndiT1983
yes, this question
10:24
panintended
yes, the original knob "button" is the one affected in such case
10:25
panintended
that is why I mentioned yesterday that I want to get the new button to come in the "foreground". Again this is is most likely because of my unfamiliarity with umgui
10:27
panintended
This has dragged on quite a bit though, I mentioned to se6ast1an that if I don't have a solution by today I can release the task for others to give it a shot
10:29
panintended
I'd like to see if I can gradually help out with more substantial aspects of the remote (like the actual firmware)
10:29
BAndiT1983
take your time, but it would be interesting to know how clicking is handled
10:30
BAndiT1983
if you add the other button on top, i would suspect that it should be handled first, but drawn last
10:34
panintended
Yes, I'm adding a button exactly where the InvisibleButton of the knob is (and with the same dimensions). it is indeed drawn last (the knob image is drawn on top of it), but again the knob is affected instead of the new button
10:35
panintended
i.e. the knob is rotating and the debug messages I added if the new button is clicked are not displayed in stdout
10:36
BAndiT1983
this is quite interesting, would have suspected that it work in reverse of draw order
10:37
BAndiT1983
just tested it quickly, no hovering event happens
10:38
panintended
what do you mean? you uncommented the is_hovered line? because for me it worked
10:38
panintended
or something else?
10:40
BAndiT1983
i've just added a button in the center and tried to hover with the mouse over it
10:40
BAndiT1983
no change in color happened, so events are consumed by invisible button first
10:41
BAndiT1983
this is what makes me also wonder what else is available in the lib and if it can be helpful -> https://github.com/ocornut/imgui/issues/2464
10:45
BAndiT1983
maybe not the direct solution, but there is a flag to flatten child structure, which allows to detect hovering: https://github.com/ocornut/imgui/issues/2051
10:48
BAndiT1983
set higher width, so it's outside of the knob also, it's working as long as the mouse is not inside the knob, definitely some obstacle there
10:50
panintended
yes, in a sentence, this has been exactly what I've been fighting width :D
10:50
BAndiT1983
ok, moved drawing before invisible button and it's active on hovering, even if the other half is beyond the knob, so the order is still top-down and not Z-index
10:50
panintended
let me give it a shot
10:50
BAndiT1983
now we have hen-egg principle ;) but at the moment i miss a clue what to search for
10:51
BAndiT1983
although i have an idea, as there is a color picker control and it has similar things, also invisible button is used
10:52
BAndiT1983
maybe a second invisible button for the area of the real button and then checking is active for the second one
10:52
BAndiT1983
like invisible button for click area -> invisible button for knob area -> draw real button for click
10:53
BAndiT1983
but i'm sure there are easier and better methods
10:53
BAndiT1983
will try beginchild, if it has different beahvior
10:54
BAndiT1983
works!
10:55
BAndiT1983
try to append to the end of the knob function -> https://pastebin.com/q7nu20DJ
10:55
BAndiT1983
it's not properly centered and sizes were changed for testing, but it's a little problem
10:57
panintended
indeed!
10:59
panintended
ah, so beginchild creates a new context (or sorts)
10:59
BAndiT1983
now your simulation can get some UI ;)
10:59
BAndiT1983
yep, like a group which is on top
11:01
BAndiT1983
some restyling for the visualiser is also required, to bring the buttons into the form of real ones
11:01
panintended
thanks, I can continue with this solution for the knob press if you also agree
11:02
BAndiT1983
no problem, please do
11:03
panintended
I'd imagine the restyling would not be terribly difficult. and besides the main purpose of the visualizer would be to test certain aspects of the firmware without having the hardware at hand, correct?
11:05
panintended
btw I noticed that some functions use pointers instead of references (and c strings instead of std::string, etc.) in their arguments -- e.g. Knob(), HandleActiveKnob()
11:06
panintended
is this for some sort of compliance or can I change that?
11:06
BAndiT1983
yes, also the virtual camera preview is exactly for that purpose, it will use virtual serial port to ensure that commands forth and back are handled by "real" handlers, which would be hardware-agnostic
11:06
BAndiT1983
probably not cleaned up properly back then
11:09
panintended
Ok, I can change these too then (in a separate PR)
11:12
BAndiT1983
great!
11:17
metal_dent[m]
the makefile is ready!
11:18
BAndiT1983
very good, have you committed it to your repo?
11:19
metal_dent[m]
no, there's a little problem with the conversion process
11:19
BAndiT1983
which one?
11:19
metal_dent[m]
as before the images where black with white background but now it's reverse in the new process so I need to change the DrawIcon() method a bit
11:21
BAndiT1983
wait, DrawIcon() is good like it is, please adjust the conversion process
11:21
BAndiT1983
-negate or +negate
11:22
BAndiT1983
black background and white icon is what it was before and should stay like that, much more intuituve
11:22
BAndiT1983
*intuitive
11:29
BAndiT1983
changed nick to: BAndiT1983|away
11:30
BAndiT1983|away
changed nick to: BAndiT1983
12:52
BAndiT1983
changed nick to: BAndiT1983|away
13:17
metal_dent[m]
committed
13:18
metal_dent[m]
but I still think the makefile can look better and somethings can be added to that, will do that
13:53
BAndiT1983|away
changed nick to: BAndiT1983
13:57
BAndiT1983
metal_dent[m]: why are you listing any file you're converting? in the makefile you have wildcards, which should allow to convert files at once, e.g. ones ending with _icon would get simple conversion and logo different approach
13:57
BAndiT1983
and not to xbm, but to header, you can use xbm:home_icon.h as target
13:59
BAndiT1983
sed is too intrusive if you have to switch forth and back, maybe it can operate on temporary file or solely in RAM, don't like that original file is modified in the process, this can break the data
14:02
BAndiT1983
ah, it's even non-destructive, no need to modify 2 times for text logo -> https://www.oreilly.com/library/view/learning-linux-shell/9781788993197/297f82a7-2122-4ca9-8b77-9d941325c310.xhtml
14:04
BAndiT1983
but it needs proper command to do it in-place without overwriting the file
14:10
BAndiT1983
or at least temporary file, which has to be removed later, to keep repo clean, either through gitignore or rm in makefile
14:33
se6ast1an
did anyone test the fullscreen parameter menu GUI yet, will create a screencapture video soon
14:33
Bertl_zZ
changed nick to: Bertl
14:33
Bertl
morning folks!
14:33
BAndiT1983
not yet, still on separat, but will try to mergee branch
14:34
BAndiT1983
*dammit, touchpad moved the cursor: still on separate branch, but will try to merge
14:37
se6ast1an
right
14:37
se6ast1an
good day Bertl
14:40
BAndiT1983
hi Bertl
14:40
BAndiT1983
se6ast1an: looks good, will check details later, as WB page would be a bit fo playground for overall menu widget testing
14:40
BAndiT1983
*of
14:46
BAndiT1983
virtual serial idea tested, will now add more code, basic idea is to use predefined ports -> socat PTY,link=/tmp/axiom_remote_port,raw PTY,link=/tmp/axiom_beta_port,raw
14:47
BAndiT1983
will also add a shell script to start socat and visualiser afterwards, could also send data just inside the application, but wanted to have "real" connection also for later, like showing board framebuffer in visualiser or sending button command from vis to board
14:48
se6ast1an
great
14:48
se6ast1an
what is the current status of the knob pushbutton in visualizer?
14:57
se6ast1an
as I might want to show that as well in the video
15:09
panintended
se6ast1an: I've got it working after consulting with BAndiT1983. currently doing some polishing before opening a PR
15:09
panintended
when will you need it?
15:22
se6ast1an
great
15:22
se6ast1an
just push when you are ready
15:23
se6ast1an
will record video today or tomorrow
15:58
BAndiT1983
changed nick to: BAndiT1983|away
15:59
BAndiT1983|away
changed nick to: BAndiT1983
16:06
BAndiT1983
changed nick to: BAndiT1983|away
16:27
metal_dent[m]
I couldn't find a proper method of converting xbm to header so I'm thinking of using "sed" and copying contents from xbm to the header
16:28
Bertl
good choice, or gawk if you need more context
16:29
metal_dent[m]
or can write a short python program for this purpose
16:30
Bertl
probably overkill, but an option as well
16:32
Bertl
got an example of the input and output format?
16:33
metal_dent[m]
input file -> https://github.com/apertus-open-source-cinema/AXIOM-Remote/blob/dev/Firmware/Media/Icons/monoRingLogo.xbm
16:33
metal_dent[m]
output file -> https://github.com/apertus-open-source-cinema/AXIOM-Remote/blob/dev/Firmware/Media/Icons/ApertusRingLogo.h
16:36
Bertl
so, most likely you want to change the pixel_data_ring to pixel_data[]; and make the struct itself generic
16:36
Bertl
i.e. no need to have a separate struct for every image, but that's unrelated :)
16:38
Bertl
the data is already in the right format, so all you need is to add the width and height
16:39
Bertl
if you make the struct generic, you can put it into a separate include file and have just the struct and data in the converted include
16:41
Bertl
alternative approach would be to use the .xbm file as is (i.e. include it) and make the struct contain a const char * to the .xbm data simply using the monoRingLogo_width and monoRingLogo_height in the struct
16:44
Bertl
something like:
16:44
Bertl
https://pastebin.com/raw/T3FeM8P5
16:46
metal_dent[m]
this looks nice but I think BAndiT1983 doesn't want any xbm files
16:48
Bertl
why?
16:49
metal_dent[m]
or maybe I misunderstood :/
16:50
Bertl
well, I have no clue what he wants or doesn't want there, but it might be worth checking :)
16:53
panintended
BAndiT1983: I've opened a PR https://github.com/apertus-open-source-cinema/AXIOM-Remote/pull/16
16:53
panintended
I also included the cleanup I mentioned earlier, I hope I didn't go too crazy :D
16:54
panintended
Waiting for your feedback
16:54
panintended
I'm going for a run, will check when I'm back
16:54
se6ast1an
great, thanks, will wait for bandits review to test it
16:58
panintended
:)
17:03
BAndiT1983|away
changed nick to: BAndiT1983
17:05
BAndiT1983
Bertl: as we have headers, no need to have .xbm there
17:05
BAndiT1983
also generic struct is there, called Icon, which can be used to cast to general attributes, like width, height and data
17:06
Bertl
the xbm is intended for C inclusion, why convert it?
17:07
BAndiT1983
what i mean is the extension, it's still XBM, but the extension should be changed while IM conversion e.g. xbm:home_icon.h
17:08
Bertl
well, if you like to rename .xbm to .h, sure, why not, might be confusing but will work with any extension
17:08
BAndiT1983
panintended: nice, rectangle button area would be also ok, was just a bit overwhelmed by the number of attributes there
17:09
BAndiT1983
will merge now
17:09
BAndiT1983
Bertl: it's just for straight approach, could be confusing otherwise when people don't know what XBM format is
17:13
BAndiT1983
panintended: it works good, but i can't find a visual indicator, or should the image of the knob be extended?
17:17
illwieckz
left the channel
17:19
BAndiT1983
also what do you mean with corners interfering with knob rotation in your comment? while testing it was no problem to rotate the knob or click the button, no hiccups also during rotating the knob and going with the mouse over the button (mine was smaller, as we don't need a very large button)
17:20
se6ast1an
tested as well, great work
17:20
se6ast1an
just pushed a small fix from my side to fix an issue with the fullscreen parameter menu
17:21
se6ast1an
what are your ideas/plans for the knob button indicator?
17:21
BAndiT1983
me or panintended?
17:22
se6ast1an
whoever feels responsible :)
17:23
BAndiT1983
line 111, replace InvisibleButton with Button and replace text there by Click, then the area is visible
17:24
BAndiT1983
without it someone, who has never used the app, will never know that it's clickable
17:24
BAndiT1983
button is a bit too large, so line 17 can be 0.3 * knobDiameter
17:25
BAndiT1983
and "round" button could be done ->
17:25
BAndiT1983
https://pastebin.com/eXRNR8U1
17:30
se6ast1an
tested, yeah thats a good improvement
17:31
se6ast1an
the button only turns "visible" when hovering over it though
17:31
BAndiT1983
we can make things a bit more simple, as imgui has proper methods to detect hovering etc.
17:31
se6ast1an
we could alter the knob graphic though
17:31
BAndiT1983
you can comment the if() for now, area detection there
17:32
BAndiT1983
that was also the idea, maybe we can have invisible button with light overlay when over click area, when image is adjusted
17:32
BAndiT1983
low hanging fruit with the image, will create the comment in the lab
17:33
BAndiT1983
ah, sub-task is better
17:34
BAndiT1983
done
17:34
BAndiT1983
https://lab.apertus.org/T1196
17:38
se6ast1an
video released
17:38
se6ast1an
https://lab.apertus.org/T1177#17079
17:38
BAndiT1983
seen it, nice!
17:40
se6ast1an
thanks!
17:47
BAndiT1983
besides menu transitions we have almost all of the features of the old firmware and also more, like LVP reading in bootloader
17:48
BAndiT1983
or do we still have some bigger block which is not covered yet at all?
17:54
panintended
Hi guys, I'm back
17:54
se6ast1an
indeed we are making very good progress
17:55
se6ast1an
great panintended, wonderful work
17:55
se6ast1an
would you be interested in this as your next task?
17:55
se6ast1an
https://lab.apertus.org/T1185
17:56
panintended
nah, I was lucky that I had BAndiT1983 there to bug when I needed help :)
17:56
panintended
ah, let me have a look
17:57
BAndiT1983
it's one of my tasks to be available for discussions and helping when required, so it's not bugging at all
17:58
BAndiT1983
nice task, was already thinking about it today, but decided that serial connection is what i have to finish for the visualiser first
17:58
panintended
I've been over this task before. Can you elaborate? What is the need for BUTTON_UP events from a functional perspective
17:58
BAndiT1983
could be that we have to restructure the button handling, so the events are separated, like button IDs of the remote and button up and down in separate enum
17:58
BAndiT1983
highlighting of buttons
17:59
BAndiT1983
when you press down many are highlighted in orange and then released action happens
18:00
BAndiT1983
merely visual thing, could also be accomplished with just a slight delay, like 200ms before action and without button event
18:00
panintended
BAndiT1983: btw, just saw your comments for the PR
18:00
BAndiT1983
but events are also important for continuous activity
18:00
metal_dent[m]
> I couldn't find a proper method of converting xbm to header so I'm thinking of using "sed" and copying contents from xbm to the header
18:00
metal_dent[m]
BAndiT1983 what do you think about this?
18:00
BAndiT1983
panintended: and, what do you think?
18:01
BAndiT1983
metal_dent[m]: now i will write it the third time: use xbm:home_icon.h as target, the "xbm:" notation in front of it defines the format, that's it
18:02
metal_dent[m]
sorry there are too many messages... i missed it
18:03
Bertl
BAndiT1983: could you repeat that for me? :)
18:03
BAndiT1983
no UI for you, Bertl ;)
18:04
BAndiT1983
https://www.youtube.com/watch?v=1jSTiKHOFEI
18:06
BAndiT1983
ImGui::Button(" 7m "); if (ImGui::IsItemClicked(0)) { enable_7m = !enable_7m; }
18:06
BAndiT1983
panintended: the lines from this thread are looking useful -> https://github.com/ocornut/imgui/issues/1537
18:09
BAndiT1983
Bertl: although it reminds me more of the rock, paper, scissors, lizzard, spock scene from big bang theory -> "could you repeat it again?"
18:19
panintended
BAndiT1983, regarding the PR: I basically went with a circular clickable area becaused I presumed that (1) a big part of the knob should be pressable without the need for a visual cue (I guess to be similar to a real life remote) and (2) following that, when using a large rectangular clickable area, if the user unknowingly clicks on the corner of the area first, the knob wasn't rotatable.
18:20
panintended
About the attributes, I hope I didn't go too OCD. The intention was to have clarity as to what each vector/number corresponds to (e.g. to a newcomer)
18:21
BAndiT1983
PR was very good, some smaller adjustments were required, visualiser should represent real hardware, but we should give people visual cues, thinking of newcomers in first place, which have never seen the remote in real
18:21
panintended
ok, let me a look
18:22
panintended
* mean have a look at the link you sent
18:22
BAndiT1983
understood it that way
18:22
BAndiT1983
area code works great, knob image has to be adjusted for proper indication, but that's a small thing
18:23
panintended
ok :)
19:27
illwieckz
joined the channel
19:35
panintended
BAndiT1983: OK, I've had a look at the actual firmware code. Things make more sense now
19:36
panintended
I'll assign T1185 to myself, OK?
19:36
BAndiT1983
yes, of course
19:36
panintended
cool
19:37
BAndiT1983
all the unclaimed items are free to claim
19:49
panintended
left the channel
20:21
panintended_
joined the channel
20:22
panintended_
changed nick to: panintended22
20:28
panintended22
left the channel
20:46
BAndiT1983
changed nick to: BAndiT1983|away
20:56
se6ast1an
off to bed, good night
21:27
Bertl
off to bed now as well ... have a good one everyone!
21:27
Bertl
changed nick to: Bertl_zZ
21:37
panintended
joined the channel