| 23:07 | HEGAZY | left the channel |
| 23:07 | HEGAZY | joined the channel |
| 23:13 | illwieckz | left the channel |
| 23:26 | illwieckz | joined the channel |
| 23:46 | HEGAZY | left the channel |
| 04:16 | metal_dent[m] | BAndiT1983: Hi, I drew the image but it looks distorted. Is it because we are converting it from the original image?
|
| 04:17 | metal_dent[m] | the text looks gothic 😅
|
| 04:28 | Bertl | can you take a screenshot?
|
| 05:29 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 06:12 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 06:48 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 07:04 | BAndiT1983 | metal_dent[m]: could you upload your code to your fork?
|
| 07:17 | metal_dent[m] | BAndiT1983: I pushed it
|
| 07:17 | BAndiT1983 | ok, will take a look
|
| 07:18 | BAndiT1983 | looks like you've got more files there, can you remove them please, as they clutter up the repo
|
| 07:18 | metal_dent[m] | okay
|
| 07:19 | BAndiT1983 | where are the .fuse ones coming from?
|
| 07:21 | BAndiT1983 | i would suggest also to remove the intermediate PNG files, as your script would take care to create the final header file from SVG
|
| 07:22 | metal_dent[m] | yes I forgot to remove them
|
| 07:22 | metal_dent[m] | I'll do that and then push
|
| 07:23 | BAndiT1983 | no big problem, but it helps a lot to keep the repo clean
|
| 07:23 | BAndiT1983 | will comment a bit on github
|
| 07:23 | metal_dent[m] | okay!
|
| 07:28 | BAndiT1983 | done
|
| 07:30 | BAndiT1983 | only commented on general things for now, but check the loops again, if they can be made simpler, when i have proper internet connection, then i would clone your repo and abuild it on my machine
|
| 07:31 | BAndiT1983 | also be aware of the origin, which is at the top-left corner, "- yIndex" implies that you are iterating the lines backwards, which would degrade performance and is counter-intuitive
|
| 07:35 | BAndiT1983 | example -> https://processing.org/tutorials/pixels/imgs/pixelarray2d.jpg
|
| 07:38 | Bertl | off to bed now ... have a good one everyone!
|
| 07:38 | Bertl | changed nick to: Bertl_zZ
|
| 07:42 | HEGAZY | joined the channel |
| 07:44 | HEGAZY | left the channel |
| 08:07 | ashok_singh[m] | left the channel |
| 08:07 | futarisIRCcloud | left the channel |
| 08:07 | danieel | left the channel |
| 08:43 | ashok_singh[m] | joined the channel |
| 08:43 | futarisIRCcloud | joined the channel |
| 08:43 | danieel | joined the channel |
| 08:45 | ashok_singh[m] | left the channel |
| 09:08 | ashok_singh[m] | joined the channel |
| 09:16 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 09:44 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 10:07 | ashok_singh[m] | BAndiT1983: I have made some changes and squashed them up. Please review them.
|
| 10:14 | BAndiT1983 | done
|
| 10:25 | ashok_singh[m] | BAndiT1983 would you please hint me how can I solve the incremental/decremental nesting.
|
| 10:26 | rahul_ | joined the channel |
| 10:27 | ashok_singh[m] | I got the solution to reduce the computations though. Am currently working on it.
|
| 10:27 | BAndiT1983 | ashok_singh[m]: nope, otherwise i could also just solve the challenge myself, the goal of the student is to show how to approach real feature request and being able to implement good readable code
|
| 10:41 | ashok_singh[m] | I have tried to solve the nested increment and reduce some computations too, but am not sure if it is the correct way. So, it would be nice if you would review the changes.
|
| 10:47 | BAndiT1983 | have to do it later, am busy with other firmware improvements at the moment
|
| 10:49 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 10:50 | ashok_singh[m] | Okay fine BAndiT1983 thanks I will be waiting for your review.
|
| 12:01 | metal_dent[m] | BAndiT1983: Thank you for your review, I'll do the necessary changes and push again :)
|
| 14:10 | Bertl_zZ | changed nick to: Bertl
|
| 14:10 | Bertl | morning folks!
|
| 14:20 | se6ast1an | good day
|
| 14:24 | HEGAZY | joined the channel |
| 15:03 | gsalazar | joined the channel |
| 15:13 | HEGAZY | left the channel |
| 15:51 | HEGAZY | joined the channel |
| 16:21 | HEGAZY | left the channel |
| 16:42 | HEGAZY | joined the channel |
| 16:54 | HEGAZY | left the channel |
| 16:55 | HEGAZY | joined the channel |
| 17:25 | pratyush | joined the channel |
| 17:37 | pratyush | left the channel |
| 18:03 | gsalazar | left the channel |
| 18:47 | gsalazar | joined the channel |
| 19:01 | gsalazar | left the channel |
| 19:01 | gsalazar | joined the channel |
| 19:19 | HEGAZY | left the channel |
| 19:34 | HEGAZY | joined the channel |
| 19:37 | gsalazar | left the channel |
| 19:38 | gsalazar | joined the channel |
| 20:15 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 20:33 | Bertl | off for now ... bbl
|
| 20:33 | Bertl | changed nick to: Bertl_oO
|
| 20:41 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 21:01 | HEGAZY | left the channel |
| 21:09 | HEGAZY | joined the channel |
| 21:21 | HEGAZY | left the channel |
| 21:21 | HEGAZY | joined the channel |
| 22:51 | gsalazar | left the channel |