03:24 | calle__ | joined the channel | |
03:28 | mumptai_ | left the channel | |
03:30 | ashok_singh[m] | joined the channel | |
06:05 | Bertl_oO | off to bed now ... have a good one everyone!
| |
06:05 | Bertl_oO | changed nick to: Bertl_zZ
| |
06:09 | metal_dent[m] | Bertl_oO: nn!
| |
07:25 | panintended | joined the channel | |
09:33 | philippe_jjj[m] | joined the channel | |
09:34 | philippe_jjj[m] | changed nick to: PhilippeJadin[m]
| |
09:36 | panintended | left the channel | |
09:37 | panintended | joined the channel | |
10:03 | BAndiT1983|away | changed nick to: BAndiT1983
| |
10:28 | LordVan | left the channel | |
10:33 | LordVan | joined the channel | |
11:28 | BAndiT1983 | hi metal_dent[m], how is it going? what's the progress?
| |
11:30 | metal_dent[m] | going good, searching for different ways to replace switch-case, also studying the remote schema :)
| |
11:32 | BAndiT1983 | please focus on the side bar first, otherwise you will have too many topics ongoing
| |
11:33 | BAndiT1983 | switch/case is another topic and requires knowledge about event systems, you can refer to the link i've posted some days ago or search google for C++ event handling, but if possible without templates, as we don't need fancy things on the microcontroller, of the case were different then i would look more strict at the code
| |
11:33 | BAndiT1983 | *if the case
| |
11:33 | metal_dent[m] | yes but schema is imp for the gsoc, right?
| |
11:34 | BAndiT1983 | imp? https://dungeonkeeper.fandom.com/wiki/Imp
| |
11:35 | metal_dent[m] | facepalm i meant important ':D
| |
11:36 | BAndiT1983 | which schema are you referring to? we have some of them
| 11:36 | metal_dent[m] | posted a file: remote_v0.14.pdf (164KB) < https://matrix.org/_matrix/media/r0/download/matrix.org/FdamfdvcgeEStwqdABgZRwds >
|
11:37 | metal_dent[m] | this one
| |
11:38 | BAndiT1983 | that's good to know the structure, have you also seen the basic structure image in the docs folder?
| |
11:39 | BAndiT1983 | have started to create it to understand which parts are available
| |
11:39 | metal_dent[m] | oh, haven't checked out that yet
| |
12:25 | se6ast1an | metal_dent[m]: I have a new small that I need help with, I implemented checkbox style options yesterday (on/off) toggling, now and icon checked/unckecked would be cool there
| |
12:25 | se6ast1an | will create video of the progress now
| |
12:27 | metal_dent[m] | cool, what's the task number?
| |
12:27 | se6ast1an | https://lab.apertus.org/T1177
| |
12:31 | se6ast1an | https://lab.apertus.org/T1177#17009
| |
12:31 | se6ast1an | video added
| |
12:32 | BAndiT1983 | se6ast1an: maybe when parameter menu pops up also the parameter should be highlighter, to show which one will change
| |
12:33 | se6ast1an | yes, it should be excluded from dimming, that would help with UX
| |
12:35 | se6ast1an | the more resource saving approach here (instead of drawing and then dimming) would be to add a new dimmed-background color to header and menu items I guess, what do you think?
| |
12:36 | BAndiT1983 | this is too complex, it's easier to add "pixel modifier" which affects drawpixel, like i'Ve described before: when parameter menu is toggled, enable dim drawing, draw menu, disable dim, draw parameter menu
| |
12:36 | BAndiT1983 | this would happen in one pass, without iterating over the whole framebuffer
| |
12:36 | BAndiT1983 | enable dimming would modify the behavior of DrawPixel() with your calculation
| |
12:37 | se6ast1an | but how would you differenciate between the highlighted and the none-highlighted menu items in background then?
| |
12:38 | BAndiT1983 | we can exclude the selected menu item from dimming or easier way, just draw that portion again, as it'S relatively small
| |
12:39 | BAndiT1983 | or at least with brighter text
| |
12:40 | se6ast1an | that will need some thought as the popupparameter menu draw() method dims the background but doesnt know anything about the menu items in the background
| |
12:41 | BAndiT1983 | yep, have to check the latest state yet, as the black screen issue was very prominent yesterday
| |
12:41 | BAndiT1983 | i love zsh, it saves a lot of typing!
| |
12:43 | BAndiT1983 | a bit of offtopic, trying to install fusion360 in linux at the moment, this would allow to create models on my laptop, instead of needing my big desktop
| |
12:44 | se6ast1an | metal_dent[m]: do you understand what I mean with the checkbox icon and where it would be supposed to be placed?
| |
12:54 | PhilippeJadin[m] | left the channel | |
12:56 | metal_dent[m] | i looked at the task but would be great if you can explain a bit
| |
12:58 | se6ast1an | the task t1177 is not relevant to what is needed here
| |
13:01 | BAndiT1983 | we need a new widget for that, so it's separated from the rest, this also applies to the UI itself
| |
13:05 | se6ast1an | so what do you propose BAndiT1983?
| |
13:05 | BAndiT1983 | create a checkbox as widget, derive it from IWidget of course
| |
13:05 | BAndiT1983 | this allows to reuse controls anywhere in the UI
| |
13:08 | BAndiT1983 | further the menu entries have to be separated, e.g. BooleanMenuEntry, RangeMenuEntry or so, then it will take care of handling data and drawing, menu just calls Draw() for all the items and doesn't care
| |
13:09 | BAndiT1983 | menu would only supply the position and dimensions for drawing
| |
13:12 | metal_dent[m] | we'll need a checkbox image?
| |
13:13 | BAndiT1983 | 2, disabled and enabled
| |
13:14 | metal_dent[m] | okay
| |
13:18 | BAndiT1983 | how about the idea to draw the disabled with a slightly darker gray than the background of the menu entry and enabled in black?
| |
13:19 | metal_dent[m] | yeah, same image but different colours with different states
| |
13:20 | BAndiT1983 | not same image
| |
13:20 | BAndiT1983 | e.g. disabled one has a rectangle with rounded corners, but enabled one has also a check mark inside
| |
13:21 | BAndiT1983 | example: https://image.shutterstock.com/image-vector/checkbox-set-blank-checked-line-260nw-1062630557.jpg
| |
13:21 | metal_dent[m] | okay, and with which button we'll place it?
| |
13:21 | BAndiT1983 | example 2: https://de.cleanpng.com/png-gapkka/
| |
13:22 | BAndiT1983 | what do you mean?
| |
13:22 | metal_dent[m] | will it be inside the menu list?
| |
13:22 | BAndiT1983 | it will replace current "on/off" options for a menu entry
| |
13:35 | se6ast1an | example 1 would get my vote
| |
13:37 | se6ast1an | should we create a new lab task for this task?
| |
13:39 | BAndiT1983 | yes, it should be visible who works on what
| |
13:40 | se6ast1an | agreed
| |
13:40 | se6ast1an | on it
| |
13:41 | BAndiT1983 | have claimed the menu task, parameter menu class is already looking like a good progress, but have to check more
| |
13:41 | se6ast1an | great
| |
13:43 | se6ast1an | please adapt https://lab.apertus.org/T1193
| |
13:43 | se6ast1an | I left out the menu item seperation into its own classes as that is an additiona task
| |
13:44 | se6ast1an | metal_dent[m]: feel free to claim it or add more questions/ thoughts in there
| |
13:44 | metal_dent[m] | sure!
| |
14:26 | se6ast1an | but as BAndiT1983 recommended I would focus on the sidebar for now, you are pretty far already if I recall correctly?
| |
14:26 | BAndiT1983 | yes, please finish the sidebar task first
| |
14:35 | Bertl_zZ | changed nick to: Bertl
| |
14:35 | Bertl | morning folks!
| |
14:36 | se6ast1an | good day!
| |
14:37 | metal_dent[m] | > but as BAndiT1983 recommended I would focus on the sidebar for now, you are pretty far already if I recall correctly?
| |
14:37 | metal_dent[m] | What are the next steps for that (apart from a better image conversion method)?
| |
14:38 | se6ast1an | link to current stage please
| |
14:39 | metal_dent[m] | I sent the screenshot a few days back, the ImageButton and _leftButtonBar are ready
| |
14:40 | se6ast1an | did you create a PR already?
| |
14:42 | metal_dent[m] | no, not yet
| |
14:42 | se6ast1an | please do
| |
14:42 | metal_dent[m] | okay!
| |
15:02 | se6ast1an | reading PR
| |
15:03 | se6ast1an | did you also add an example ImageButton in the left sidebar? I cant see one in the PR?
| |
15:04 | metal_dent[m] | no, I had added to check whether it's working or not in the WB screen but then removed it
| |
15:05 | se6ast1an | please readd it, we want to see it working as well :)
| |
15:05 | metal_dent[m] | okay, sure
| |
15:25 | PhilippeJadin[m] | joined the channel | |
15:25 | PhilippeJadin[m] | (for what it's worth, using riot.im client, you can connect to irc and have irc history) - also hello everybody, have not been here for like 3 years, hehe!
| |
15:25 | se6ast1an | hello!
| |
15:25 | se6ast1an | what a pleasant surprise!
| |
15:25 | se6ast1an | how are you?
| |
15:27 | PhilippeJadin[m] | I'm fine (just replied to your mail btw), trying to take care of a 3 years old girl in those weird times where she cannot go to school and I "work" remotely
| |
15:27 | PhilippeJadin[m] | and you ?
| |
15:30 | se6ast1an | replying!
| |
15:30 | metal_dent[m] | se6ast1an: added the home button as an example in WB screen
| |
15:31 | metal_dent[m] | btw have you done something with the colours?
| |
15:32 | se6ast1an | great metal_dent[m], will check in a minute
| |
15:32 | se6ast1an | please elaborate what you mean with "something done with colors"
| |
15:33 | se6ast1an | as I always do things, often with colors :)
| |
15:33 | Bertl | bright colors?
| |
15:34 | metal_dent[m] | umm.. i mean the icon's colour is randomly changing everytime we run the visualizer (before when i checked it was only black)
| |
15:38 | se6ast1an | sounds weird, but lets see if we can reproduce that
| |
15:39 | se6ast1an | PhilippeJadin[m]: replied
| |
15:44 | se6ast1an | metal_dent[m]: looks good, lets wait for BAndiT1983s feedback and then we can merge
| |
15:44 | metal_dent[m] | Okay, thanks!
| |
15:46 | BAndiT1983 | checked already
| |
15:46 | BAndiT1983 | you can merge, everything else can be done later
| |
15:47 | se6ast1an | great, will do
| |
15:50 | se6ast1an | done
| |
15:50 | se6ast1an | many thanks metal_dent[m]!
| |
15:51 | se6ast1an | what would you like to work on next metal_dent[m]?
| |
15:51 | metal_dent[m] | Thanks for merging! se6ast1an
| |
15:52 | Bertl | metal_dent[m]: maybe re-enable compiler warnings and check for uninitialized variables :)
| |
15:57 | metal_dent[m] | Yes as I haven't given any color so it must be taking randomly from somewhere
| |
16:00 | se6ast1an | sounds like a hot lead indeed
| |
16:04 | se6ast1an | I also see now that ImageButton does not obey its width and height member variables in the draw() function
| |
16:05 | se6ast1an | also how do you make sure to draw the image/icon in the middle of the button?
| |
16:07 | se6ast1an | would you like to create a task collecting the issues?
| |
17:28 | metal_dent[m] | yes, that'd be good for tracking
| |
17:30 | metal_dent[m] | > I also see now that ImageButton does not obey its width and height member variables in the draw() function
| |
17:30 | metal_dent[m] | what do you mean?
| |
17:35 | panintended | left the channel | |
17:55 | BAndiT1983 | metal_dent[m]: you have fixed sizes for the ImageButton
| |
17:55 | BAndiT1983 | this is not really how it should be
| |
18:02 | BAndiT1983 | changed nick to: BAndiT1983|away
| |
18:03 | metal_dent[m] | yeah, so I should take the sizes from the image headers
| |
18:26 | metal_dent[m] | Will look into this tomorrow, off to bed, nn!
| |
18:27 | se6ast1an | good night
| |
18:53 | BAndiT1983|away | changed nick to: BAndiT1983
| |
19:21 | calle__ | left the channel | |
19:26 | mumptai | joined the channel | |
21:33 | lexano | left the channel | |
21:33 | lexano | joined the channel | |
22:14 | LordVan | left the channel | |
22:25 | BAndiT1983 | changed nick to: BAndiT1983|away
| |
22:28 | Nate2 | joined the channel | |
22:29 | Nate2 | left the channel | |
22:46 | mumptai | left the channel | |
22:47 | mumptai | joined the channel | |
23:49 | vup | Bertl: which rail is the PWRGD on the plugins modules supposed to belong to
| |
23:50 | vup | or is it supposed to be a and of PWGD for VCC, VCCIO and 5V?
| |
23:50 | vup | s/PWGD/PWRGD/
| |
23:52 | vup | ok on the current mainboard it isn't even connected :)
| |
00:00 | Bertl | correct, we didn't agree on whether it should be a power good or reset or both or something else :)
| |
00:04 | Bertl | off to bed now ... have a good one everyone!
| |
00:04 | Bertl | changed nick to: Bertl_zZ
| |
00:12 | vup | nn
| |
00:12 | vup | i guess i will leave it unconnected for now then :)
|