Current Server Time: 19:48 (Central Europe)

#apertus IRC Channel Logs

2019/04/03

Timezone: UTC


00:51
aSobhy
hello Bertl :)
00:58
RexOrCine|away
changed nick to: RexOrCine
00:58
aSobhy
I am working on the post implementation , I have switched to Cyclone IV as it supports the post-fitting timing and generated the files functions and time constraints ( .vho & .sdo) and currently trying to shift the cells to the I/O pins of the FPGA
01:01
Bertl
sounds good!
01:01
aSobhy
as quarus report to the
01:01
aSobhy
Fmax : 953MHz , Restricted Fmax : 250 MHz (limit due to minimum period restriction (max I/O toggle rate))
01:02
aSobhy
for the (Slow 1200mV 0C Model)
01:02
aSobhy
am i on the right path ?
01:04
Bertl
moving stuff to or into the I/O blocks is a good idea
01:05
aSobhy
ok I working on it now
01:05
aSobhy
I'am
01:07
aSobhy
another question :) should I begin to write the proposal ?
01:09
aSobhy
I'm worry not to submit the proposal on time
01:16
Bertl
yes, writing the proposal and providing a CV is essential
01:16
Bertl
so make sure to spend some quality time on that too
01:18
Bertl
also note that it is okay to write more than one proposal ... i.e. for more than one task
01:19
aSobhy
yes I was writing that question right now
01:21
aSobhy
I know that question will be weird : can you tell me what projects in vhdl that apertus have high priority in acceptance ?
01:24
aSobhy
I am interested in more than two projects :)
01:31
Bertl
well, let's see: definitely T731 and T1131 have high priority
01:33
Bertl
T887 is not high priority but probably quite interesting and the results might be quite relevant for Apertus
01:39
aSobhy
OK, and what for those T721, T1130 and T885 ?
01:42
Bertl
T885 and T721 are related to the SDI work already tackled by _florent_ and felix_ but they are still valid tasks
01:43
Bertl
T1130 is nice to have but not really required
01:46
aSobhy
so if I applied for T885 or T721 their would be a competition ?
01:48
Bertl
not really as felix_ and _florent_ are not participating as GSoC students :)
01:52
aSobhy
Okay
01:54
aSobhy
I'll have a look at T731 its sounds good after the exam tomorrow :)
01:55
Bertl
let me know if you have any questions and good luck with the exam!
01:56
aSobhy
I should have questioned that question earlier :D
01:57
aSobhy
Sure, Thank you alot :)
01:57
Bertl
no problem!
03:57
Bertl
off to bed now ... have a good one everyone!
03:57
Bertl
changed nick to: Bertl_zZ
04:13
RexOrCine
changed nick to: RexOrCine|away
05:19
BAndiT1983|away
changed nick to: BAndiT1983
05:26
aSobhy
left the channel
05:49
RexOrCine|away
changed nick to: RexOrCine
06:04
BAndiT1983
changed nick to: BAndiT1983|away
06:24
dcz
joined the channel
06:50
se6astian|away
changed nick to: se6astian
07:22
Spirit532
left the channel
07:23
Spirit532
joined the channel
07:30
se6astian
changed nick to: se6astian|away
07:43
dcz
left the channel
08:02
sebix
joined the channel
09:36
RexOrCine
changed nick to: RexOrCine|away
09:37
se6astian|away
changed nick to: se6astian
09:50
dcz
joined the channel
10:01
Y_G
joined the channel
10:06
se6astian
changed nick to: se6astian|away
10:21
Y_G
left the channel
10:39
futarisIRCcloud
left the channel
12:20
se6astian|away
changed nick to: se6astian
13:12
Bertl_zZ
changed nick to: Bertl
13:12
Bertl
morning folks!
13:33
dazzy
joined the channel
13:33
dazzy
hello
13:34
dazzy
how i submit proposal?
13:34
Bertl
hello dazzy!
13:35
Bertl
it would be a good idea to send the proposal together with a link to your CV and challenge task to one of the mentors listed for the task you are applying for
13:36
Bertl
but the actual submission is done via GSoC
13:37
dazzy
how could i found that link?
13:37
Bertl
which one?
13:37
Bertl
here is an overview: https://wiki.apertus.org/index.php/GSoC_Overview
13:38
dazzy
ok
13:39
dazzy
can i submit this link?
13:40
Bertl
I think you are a little confused ... maybe read the Overview and some GSoC docs first
13:41
dazzy
ok
13:52
dazzy
left the channel
14:12
apurvanandan[m]
Hi Bertl
14:13
apurvanandan[m]
I have done the formatting and code is also working at 600 MHz
14:13
apurvanandan[m]
I have pushed the code on GitHub
14:14
apurvanandan[m]
Code can be synthesized and simulated by make command
14:14
apurvanandan[m]
Usage of make command is written in README
14:14
apurvanandan[m]
Shall I message you the link to the repo
14:27
Bertl
yes please
14:31
intrac
left the channel
14:32
intrac
joined the channel
14:50
dcz_
joined the channel
14:50
dcz
left the channel
15:01
se6astian
changed nick to: se6astian|away
15:33
BAndiT1983|away
changed nick to: BAndiT1983
15:35
saurabh_raj
joined the channel
15:36
saurabh_raj
Hello. BAndiT1983
15:36
BAndiT1983
hi saurabh_raj
15:37
saurabh_raj
you told me yesterday that use of pragma pack should be avoided. How about __attribute__((packed)) , I am asking as I found mixed opinions about this too on forums
15:38
BAndiT1983
why do you need it in first place?
15:39
saurabh_raj
to pack the structs of bitmap, when I write the structs without packing them the output file is corrupted
15:40
BAndiT1983
is the structure not padded?
15:40
saurabh_raj
yes
15:41
BAndiT1983
yes, padded, or no, not padded?
15:41
saurabh_raj
not padded
15:41
BAndiT1983
are you sure? have you tried it without?
15:41
saurabh_raj
yes
15:43
BAndiT1983
first question is, why is you bmp header using char as first type?
15:43
BAndiT1983
isn't a character usually unsigned char?
15:43
saurabh_raj
yeah I have changed it to uint8_t now
15:43
BAndiT1983
or maybe also uint8_t?
15:44
saurabh_raj
I will update the code soon, made many major changes today
15:45
BAndiT1983
don't see any possible packing problems there, so please verify it again, as pragma pack of 2 is rather unusual there
15:45
BAndiT1983
have you checked C++ guidelines also?
15:46
BAndiT1983
as i see many problems whcih relate to OOP and naming of constants, also global definitions are bad, as they can be redefined elsewhere in the code, which can lead to serious problems in real applications
15:48
BAndiT1983
also placing includes in the header can be avoided by using forward declaration
15:49
BAndiT1983
and don'T forget to have a lot more consistency, like header guards have to be in upper-case
15:49
BAndiT1983
as consistent and readable code is telling us while code review, that the student is taking the task seriously
15:53
saurabh_raj
I have updated the code, simplified the demosaicing process, and added avi writing
15:54
BAndiT1983
i would focus on quality not quantity, as there are many problems and a lot of obfuscations
15:55
BAndiT1983
performance-wise there is also a big problem, as you have separate structure for pixel, which would kill performance as you push data there one by one
15:56
BAndiT1983
i don't see much OOP there, please consider to add classes, as everything is rather C-ish with touches of C++
15:56
saurabh_raj
so should I store the data in a buffer array and write it all once ?
15:57
BAndiT1983
for example
15:57
BAndiT1983
also one .cpp and .h for a class, not everything in one place
15:57
BAndiT1983
think about proper pipeline structure, as at the moment it's everything mashed up in different sections
15:59
saurabh_raj
okey.. I will try to organize it all better.
16:00
dcz_
left the channel
16:00
BAndiT1983
you can get some ideas from here -> https://stackoverflow.com/questions/46656699/modeling-a-pipeline-in-c-with-replaceable-stages
16:01
BAndiT1983
it hasn't to be totally advanced, but i want to see proper separation of input, processing and output
16:01
BAndiT1983
if i'm not mistaken, then just one data object is required to hold image data and to be suitable for the whole pipeline
16:02
saurabh_raj
yeah.. I have an object like that of the Channels class, it has three arrays which contain channel data
16:03
BAndiT1983
ehm, why?
16:03
BAndiT1983
why do you need separate channels model?
16:03
BAndiT1983
isn't an image object enough?
16:05
saurabh_raj
yeah.. I can triple the size of the array then it can hold all three, will just have to take little extra care while demosaicing.. it can have member functions for initializing the array and demosaicing
16:06
BAndiT1983
demosaicing inside the image object?
16:06
saurabh_raj
Yes, will that be good? Or should I have a seperate class for demosaicing?
16:08
BAndiT1983
please read about OOP principles and application structure, as i have given enough hints and not in the mood after work to do more code review, doing it enough through the day
16:08
saurabh_raj
okey sure, I will go though the links and additional documents. Thanks for help.
16:09
BAndiT1983
off for now, will be back later
16:09
BAndiT1983
changed nick to: BAndiT1983|away
16:19
se6astian|away
changed nick to: se6astian
16:22
aSobhy
joined the channel
16:28
sebix
left the channel
16:38
AntGeorge
joined the channel
16:45
shivamgoyal
joined the channel
16:46
shivamgoyal
left the channel
17:02
AntGeorge
left the channel
17:15
BAndiT1983|away
changed nick to: BAndiT1983
17:26
saurabh_raj
left the channel
18:14
mrohit[m]
Hello, I have seen BAndit1983 mentioning that CMV register access still needs to be added to the daemon.
18:14
mrohit[m]
I had a basic doubt ,so can't we access the CMV registers through the MemoryAdapter.h present in the daemon as done in CMV12000Adapter.cpp? Is there something that I am missing here?
18:24
BAndiT1983
access to CMV is already there, so i don't know what the doubts are?
18:27
mrohit[m]
okay, even I thought so...but in the logs I have seen you mentioning that access is still not added, that's why I thought I was missing out something or probably interpreting something wrong. Anyways, now I get it
18:28
mrohit[m]
just to be clear of what I have understood. Is CMV12000Adapter doing a similar work as done in set_gain .sh in the firmware?
18:28
BAndiT1983
analog and digital gains can be controlled perfectly fine, tested it on real axiom beta through live feed
18:28
BAndiT1983
yes, the script was replicated, but also adjusted
18:31
mrohit[m]
okay
18:37
mrohit[m]
and are there any specific reasons why the MessageHandlerTests.cpp is commented out? is there something planned to change/work on?
18:38
BAndiT1983
probably
18:42
mrohit[m]
I would like to work on it if possible, that way I would learn about building UnitTests as this is something new for me
18:43
BAndiT1983
i hope with 100% code coverage
18:44
mrohit[m]
sorry, didn't get what you meant by 100% code coverage?
18:45
BAndiT1983
https://www.atlassian.com/continuous-delivery/software-testing/code-coverage
18:56
mrohit[m]
ohh...that's something I wasn't aware of...thanks :)
18:56
mrohit[m]
So is it currently evaluated automatically in the Cirrus CI builds of Axiom projects?
18:57
BAndiT1983
not that i'm aware of
18:57
BAndiT1983
cirrus is building the firmware, rest is using circle ci
19:00
mrohit[m]
oh..yes..
19:00
mrohit[m]
currently which tool is used for evaluating code coverage for the projects?
19:00
BAndiT1983
currently none, as doing coverage requires unit tests
19:00
BAndiT1983
but there are built-in coverage tools in GCC and clang which would be used for CI builds
19:02
mrohit[m]
but currently we do have a couple of Unit tests...right?
19:03
BAndiT1983
yes -> https://circleci.com/gh/apertus-open-source-cinema/axiom-control-daemon/40
19:08
mrohit[m]
okay..so we can configure circleci to generate code coverage report too, using the built-in tools from gcc
19:09
BAndiT1983
yes, but the task is not that simple, tested it already locally
19:12
mrohit[m]
okay...so that doesn't seem to work. I mean, is the build failing after adding the code coverage tool?
19:14
BAndiT1983
the process works, but it involves some advanced steps to generate reports of code coveragem based on the tests
19:16
mrohit[m]
okay..seems like I should dig deeper to know more about testing and then try to analyse the MessageHandlerTests
19:17
mrohit[m]
by the way, was the MessageHandlerTests deleted (apparently) because of low code coverage?
19:18
BAndiT1983
i see the file, so it's not deleted
19:18
BAndiT1983
but probably commented out, as the interface has changed and nobody had time to adjust tests
19:21
mrohit[m]
"interface has changed" -> which change are you referring to?
19:21
BAndiT1983
we changed the schema of data
19:24
mrohit[m]
okay..will look for the differences and try to implement the tests locally
19:54
intrac
left the channel
19:55
intrac
joined the channel
20:17
aombk2
joined the channel
20:21
aombk
left the channel
20:32
BAndiT1983
changed nick to: BAndiT1983|away
20:32
aombk3
joined the channel
20:35
aombk2
left the channel
20:37
se6astian
changed nick to: se6astian|away
21:49
Bertl
off to bed now ... have a good one everyone!
21:49
Bertl
changed nick to: Bertl_zZ
22:12
dcz_
joined the channel
22:57
dcz_
left the channel