| 01:51 | aSobhy | hello Bertl :)
|
| 01:58 | RexOrCine|away | changed nick to: RexOrCine
|
| 01:58 | aSobhy | I am working on the post implementation , I have switched to Cyclone IV as it supports the post-fitting timing and generated the files functions and time constraints ( .vho & .sdo) and currently trying to shift the cells to the I/O pins of the FPGA
|
| 02:01 | Bertl | sounds good!
|
| 02:01 | aSobhy | as quarus report to the
|
| 02:01 | aSobhy | Fmax : 953MHz , Restricted Fmax : 250 MHz (limit due to minimum period restriction (max I/O toggle rate))
|
| 02:02 | aSobhy | for the (Slow 1200mV 0C Model)
|
| 02:02 | aSobhy | am i on the right path ?
|
| 02:04 | Bertl | moving stuff to or into the I/O blocks is a good idea
|
| 02:05 | aSobhy | ok I working on it now
|
| 02:05 | aSobhy | I'am
|
| 02:07 | aSobhy | another question :) should I begin to write the proposal ?
|
| 02:09 | aSobhy | I'm worry not to submit the proposal on time
|
| 02:16 | Bertl | yes, writing the proposal and providing a CV is essential
|
| 02:16 | Bertl | so make sure to spend some quality time on that too
|
| 02:18 | Bertl | also note that it is okay to write more than one proposal ... i.e. for more than one task
|
| 02:19 | aSobhy | yes I was writing that question right now
|
| 02:21 | aSobhy | I know that question will be weird : can you tell me what projects in vhdl that apertus have high priority in acceptance ?
|
| 02:24 | aSobhy | I am interested in more than two projects :)
|
| 02:31 | Bertl | well, let's see: definitely T731 and T1131 have high priority
|
| 02:33 | Bertl | T887 is not high priority but probably quite interesting and the results might be quite relevant for Apertus
|
| 02:39 | aSobhy | OK, and what for those T721, T1130 and T885 ?
|
| 02:42 | Bertl | T885 and T721 are related to the SDI work already tackled by _florent_ and felix_ but they are still valid tasks
|
| 02:43 | Bertl | T1130 is nice to have but not really required
|
| 02:46 | aSobhy | so if I applied for T885 or T721 their would be a competition ?
|
| 02:48 | Bertl | not really as felix_ and _florent_ are not participating as GSoC students :)
|
| 02:52 | aSobhy | Okay
|
| 02:54 | aSobhy | I'll have a look at T731 its sounds good after the exam tomorrow :)
|
| 02:55 | Bertl | let me know if you have any questions and good luck with the exam!
|
| 02:56 | aSobhy | I should have questioned that question earlier :D
|
| 02:57 | aSobhy | Sure, Thank you alot :)
|
| 02:57 | Bertl | no problem!
|
| 04:57 | Bertl | off to bed now ... have a good one everyone!
|
| 04:57 | Bertl | changed nick to: Bertl_zZ
|
| 05:13 | RexOrCine | changed nick to: RexOrCine|away
|
| 06:19 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 06:26 | aSobhy | left the channel |
| 06:49 | RexOrCine|away | changed nick to: RexOrCine
|
| 07:04 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 07:24 | dcz | joined the channel |
| 07:50 | se6astian|away | changed nick to: se6astian
|
| 08:22 | Spirit532 | left the channel |
| 08:23 | Spirit532 | joined the channel |
| 08:30 | se6astian | changed nick to: se6astian|away
|
| 08:43 | dcz | left the channel |
| 09:02 | sebix | joined the channel |
| 10:36 | RexOrCine | changed nick to: RexOrCine|away
|
| 10:37 | se6astian|away | changed nick to: se6astian
|
| 10:50 | dcz | joined the channel |
| 11:01 | Y_G | joined the channel |
| 11:06 | se6astian | changed nick to: se6astian|away
|
| 11:21 | Y_G | left the channel |
| 11:39 | futarisIRCcloud | left the channel |
| 13:20 | se6astian|away | changed nick to: se6astian
|
| 14:12 | Bertl_zZ | changed nick to: Bertl
|
| 14:12 | Bertl | morning folks!
|
| 14:33 | dazzy | joined the channel |
| 14:33 | dazzy | hello
|
| 14:34 | dazzy | how i submit proposal?
|
| 14:34 | Bertl | hello dazzy!
|
| 14:35 | Bertl | it would be a good idea to send the proposal together with a link to your CV and challenge task to one of the mentors listed for the task you are applying for
|
| 14:36 | Bertl | but the actual submission is done via GSoC
|
| 14:37 | dazzy | how could i found that link?
|
| 14:37 | Bertl | which one?
|
| 14:37 | Bertl | here is an overview: https://wiki.apertus.org/index.php/GSoC_Overview
|
| 14:38 | dazzy | ok
|
| 14:39 | dazzy | can i submit this link?
|
| 14:40 | Bertl | I think you are a little confused ... maybe read the Overview and some GSoC docs first
|
| 14:41 | dazzy | ok
|
| 14:52 | dazzy | left the channel |
| 15:12 | apurvanandan[m] | Hi Bertl
|
| 15:13 | apurvanandan[m] | I have done the formatting and code is also working at 600 MHz
|
| 15:13 | apurvanandan[m] | I have pushed the code on GitHub
|
| 15:14 | apurvanandan[m] | Code can be synthesized and simulated by make command
|
| 15:14 | apurvanandan[m] | Usage of make command is written in README
|
| 15:14 | apurvanandan[m] | Shall I message you the link to the repo
|
| 15:27 | Bertl | yes please
|
| 15:31 | intrac | left the channel |
| 15:32 | intrac | joined the channel |
| 15:50 | dcz_ | joined the channel |
| 15:50 | dcz | left the channel |
| 16:01 | se6astian | changed nick to: se6astian|away
|
| 16:33 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 16:35 | saurabh_raj | joined the channel |
| 16:36 | saurabh_raj | Hello. BAndiT1983
|
| 16:36 | BAndiT1983 | hi saurabh_raj
|
| 16:37 | saurabh_raj | you told me yesterday that use of pragma pack should be avoided. How about __attribute__((packed)) , I am asking as I found mixed opinions about this too on forums
|
| 16:38 | BAndiT1983 | why do you need it in first place?
|
| 16:39 | saurabh_raj | to pack the structs of bitmap, when I write the structs without packing them the output file is corrupted
|
| 16:40 | BAndiT1983 | is the structure not padded?
|
| 16:40 | saurabh_raj | yes
|
| 16:41 | BAndiT1983 | yes, padded, or no, not padded?
|
| 16:41 | saurabh_raj | not padded
|
| 16:41 | BAndiT1983 | are you sure? have you tried it without?
|
| 16:41 | saurabh_raj | yes
|
| 16:43 | BAndiT1983 | first question is, why is you bmp header using char as first type?
|
| 16:43 | BAndiT1983 | isn't a character usually unsigned char?
|
| 16:43 | saurabh_raj | yeah I have changed it to uint8_t now
|
| 16:43 | BAndiT1983 | or maybe also uint8_t?
|
| 16:44 | saurabh_raj | I will update the code soon, made many major changes today
|
| 16:45 | BAndiT1983 | don't see any possible packing problems there, so please verify it again, as pragma pack of 2 is rather unusual there
|
| 16:45 | BAndiT1983 | have you checked C++ guidelines also?
|
| 16:46 | BAndiT1983 | as i see many problems whcih relate to OOP and naming of constants, also global definitions are bad, as they can be redefined elsewhere in the code, which can lead to serious problems in real applications
|
| 16:48 | BAndiT1983 | also placing includes in the header can be avoided by using forward declaration
|
| 16:49 | BAndiT1983 | and don'T forget to have a lot more consistency, like header guards have to be in upper-case
|
| 16:49 | BAndiT1983 | as consistent and readable code is telling us while code review, that the student is taking the task seriously
|
| 16:53 | saurabh_raj | I have updated the code, simplified the demosaicing process, and added avi writing
|
| 16:54 | BAndiT1983 | i would focus on quality not quantity, as there are many problems and a lot of obfuscations
|
| 16:55 | BAndiT1983 | performance-wise there is also a big problem, as you have separate structure for pixel, which would kill performance as you push data there one by one
|
| 16:56 | BAndiT1983 | i don't see much OOP there, please consider to add classes, as everything is rather C-ish with touches of C++
|
| 16:56 | saurabh_raj | so should I store the data in a buffer array and write it all once ?
|
| 16:57 | BAndiT1983 | for example
|
| 16:57 | BAndiT1983 | also one .cpp and .h for a class, not everything in one place
|
| 16:57 | BAndiT1983 | think about proper pipeline structure, as at the moment it's everything mashed up in different sections
|
| 16:59 | saurabh_raj | okey.. I will try to organize it all better.
|
| 17:00 | dcz_ | left the channel |
| 17:00 | BAndiT1983 | you can get some ideas from here -> https://stackoverflow.com/questions/46656699/modeling-a-pipeline-in-c-with-replaceable-stages
|
| 17:01 | BAndiT1983 | it hasn't to be totally advanced, but i want to see proper separation of input, processing and output
|
| 17:01 | BAndiT1983 | if i'm not mistaken, then just one data object is required to hold image data and to be suitable for the whole pipeline
|
| 17:02 | saurabh_raj | yeah.. I have an object like that of the Channels class, it has three arrays which contain channel data
|
| 17:03 | BAndiT1983 | ehm, why?
|
| 17:03 | BAndiT1983 | why do you need separate channels model?
|
| 17:03 | BAndiT1983 | isn't an image object enough?
|
| 17:05 | saurabh_raj | yeah.. I can triple the size of the array then it can hold all three, will just have to take little extra care while demosaicing.. it can have member functions for initializing the array and demosaicing
|
| 17:06 | BAndiT1983 | demosaicing inside the image object?
|
| 17:06 | saurabh_raj | Yes, will that be good? Or should I have a seperate class for demosaicing?
|
| 17:08 | BAndiT1983 | please read about OOP principles and application structure, as i have given enough hints and not in the mood after work to do more code review, doing it enough through the day
|
| 17:08 | saurabh_raj | okey sure, I will go though the links and additional documents. Thanks for help.
|
| 17:09 | BAndiT1983 | off for now, will be back later
|
| 17:09 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 17:19 | se6astian|away | changed nick to: se6astian
|
| 17:22 | aSobhy | joined the channel |
| 17:28 | sebix | left the channel |
| 17:38 | AntGeorge | joined the channel |
| 17:45 | shivamgoyal | joined the channel |
| 17:46 | shivamgoyal | left the channel |
| 18:02 | AntGeorge | left the channel |
| 18:15 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 18:26 | saurabh_raj | left the channel |
| 19:14 | mrohit[m] | Hello, I have seen BAndit1983 mentioning that CMV register access still needs to be added to the daemon.
|
| 19:14 | mrohit[m] | I had a basic doubt ,so can't we access the CMV registers through the MemoryAdapter.h present in the daemon as done in CMV12000Adapter.cpp? Is there something that I am missing here?
|
| 19:24 | BAndiT1983 | access to CMV is already there, so i don't know what the doubts are?
|
| 19:27 | mrohit[m] | okay, even I thought so...but in the logs I have seen you mentioning that access is still not added, that's why I thought I was missing out something or probably interpreting something wrong. Anyways, now I get it
|
| 19:28 | mrohit[m] | just to be clear of what I have understood. Is CMV12000Adapter doing a similar work as done in set_gain .sh in the firmware?
|
| 19:28 | BAndiT1983 | analog and digital gains can be controlled perfectly fine, tested it on real axiom beta through live feed
|
| 19:28 | BAndiT1983 | yes, the script was replicated, but also adjusted
|
| 19:31 | mrohit[m] | okay
|
| 19:37 | mrohit[m] | and are there any specific reasons why the MessageHandlerTests.cpp is commented out? is there something planned to change/work on?
|
| 19:38 | BAndiT1983 | probably
|
| 19:42 | mrohit[m] | I would like to work on it if possible, that way I would learn about building UnitTests as this is something new for me
|
| 19:43 | BAndiT1983 | i hope with 100% code coverage
|
| 19:44 | mrohit[m] | sorry, didn't get what you meant by 100% code coverage?
|
| 19:45 | BAndiT1983 | https://www.atlassian.com/continuous-delivery/software-testing/code-coverage
|
| 19:56 | mrohit[m] | ohh...that's something I wasn't aware of...thanks :)
|
| 19:56 | mrohit[m] | So is it currently evaluated automatically in the Cirrus CI builds of Axiom projects?
|
| 19:57 | BAndiT1983 | not that i'm aware of
|
| 19:57 | BAndiT1983 | cirrus is building the firmware, rest is using circle ci
|
| 20:00 | mrohit[m] | oh..yes..
|
| 20:00 | mrohit[m] | currently which tool is used for evaluating code coverage for the projects?
|
| 20:00 | BAndiT1983 | currently none, as doing coverage requires unit tests
|
| 20:00 | BAndiT1983 | but there are built-in coverage tools in GCC and clang which would be used for CI builds
|
| 20:02 | mrohit[m] | but currently we do have a couple of Unit tests...right?
|
| 20:03 | BAndiT1983 | yes -> https://circleci.com/gh/apertus-open-source-cinema/axiom-control-daemon/40
|
| 20:08 | mrohit[m] | okay..so we can configure circleci to generate code coverage report too, using the built-in tools from gcc
|
| 20:09 | BAndiT1983 | yes, but the task is not that simple, tested it already locally
|
| 20:12 | mrohit[m] | okay...so that doesn't seem to work. I mean, is the build failing after adding the code coverage tool?
|
| 20:14 | BAndiT1983 | the process works, but it involves some advanced steps to generate reports of code coveragem based on the tests
|
| 20:16 | mrohit[m] | okay..seems like I should dig deeper to know more about testing and then try to analyse the MessageHandlerTests
|
| 20:17 | mrohit[m] | by the way, was the MessageHandlerTests deleted (apparently) because of low code coverage?
|
| 20:18 | BAndiT1983 | i see the file, so it's not deleted
|
| 20:18 | BAndiT1983 | but probably commented out, as the interface has changed and nobody had time to adjust tests
|
| 20:21 | mrohit[m] | "interface has changed" -> which change are you referring to?
|
| 20:21 | BAndiT1983 | we changed the schema of data
|
| 20:24 | mrohit[m] | okay..will look for the differences and try to implement the tests locally
|
| 20:54 | intrac | left the channel |
| 20:55 | intrac | joined the channel |
| 21:17 | aombk2 | joined the channel |
| 21:21 | aombk | left the channel |
| 21:32 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 21:32 | aombk3 | joined the channel |
| 21:35 | aombk2 | left the channel |
| 21:37 | se6astian | changed nick to: se6astian|away
|
| 22:49 | Bertl | off to bed now ... have a good one everyone!
|
| 22:49 | Bertl | changed nick to: Bertl_zZ
|
| 23:12 | dcz_ | joined the channel |
| 23:57 | dcz_ | left the channel |