Current Server Time: 23:08 (Central Europe)

#apertus IRC Channel Logs

2018/05/01

Timezone: UTC


00:59
seaman_
left the channel
01:23
BAndiT1983|away
changed nick to: BAndiT1983
01:35
intrac
left the channel
01:50
BAndiT1983
changed nick to: BAndiT1983|away
02:27
rton
left the channel
03:29
slikdigit
left the channel
03:55
futarisIRCcloud
joined the channel
04:13
Bertl_oO
off to bed now ... have a good one!
04:13
Bertl_oO
changed nick to: Bertl_zZ
04:19
intrac
joined the channel
07:24
niemand
joined the channel
07:47
BAndiT1983|away
changed nick to: BAndiT1983
08:24
se6astian|away
changed nick to: se6astian
08:27
se6astian
changed nick to: se6astian|away
09:35
rton
joined the channel
10:08
BAndiT1983
changed nick to: BAndiT1983|away
11:06
g3gg0
joined the channel
11:10
seaman
joined the channel
11:33
ArunM
joined the channel
11:59
BAndiT1983|away
changed nick to: BAndiT1983
11:59
BAndiT1983
changed nick to: BAndiT1983|away
12:14
futarisIRCcloud
left the channel
12:18
Bertl_zZ
changed nick to: Bertl
12:18
Bertl
morning folks!
12:29
ArunM
left the channel
12:33
ArunM
joined the channel
12:50
RexOrCine|away
changed nick to: RexOrCine
13:18
BAndiT1983|away
changed nick to: BAndiT1983
13:43
BAndiT1983
changed nick to: BAndiT1983|away
13:43
BAndiT1983|away
changed nick to: BAndiT1983
14:17
TofuLynx
joined the channel
14:47
TofuLynx
Good Afternoon!
14:55
TofuLynx
BAndiT1983: You there?
14:57
BAndiT1983
hi TofuLynx, now i am
14:59
TofuLynx
Hey!
15:00
TofuLynx
I finished the bilinear debayer class, I will commit it now to my repo. Can you check it? I still have to structure it better and add patternOffsets
15:02
BAndiT1983
just do a pull request and travis ci will build it first, will look at it in parallel
15:03
TofuLynx
ok!
15:07
illwieckz
left the channel
15:08
BAndiT1983
TofuLynx, quick reboot
15:08
BAndiT1983
changed nick to: BAndiT1983|away
15:12
BAndiT1983|away
changed nick to: BAndiT1983
15:12
TofuLynx
Hello
15:13
TofuLynx
I made the PR, it has one conflict, can you solve it, please?
15:13
TofuLynx
It is related to changes you made
15:13
BAndiT1983
let me check it first, apps are still starting after reboot
15:13
BAndiT1983
somehow hyper-v was activated after big update today, so had to get rid of it for virtualbox
15:13
TofuLynx
ok! :)
15:14
BAndiT1983
hayve you pulled first?
15:14
TofuLynx
nope
15:14
TofuLynx
wait
15:14
TofuLynx
yes*
15:14
TofuLynx
i think so
15:14
BAndiT1983
that's the problem, as the newer code is different in the place of conflict
15:15
TofuLynx
I didn't pull the PreProcessor
15:15
TofuLynx
As I made changes on it
15:15
BAndiT1983
you should always pull everything, before committing
15:15
TofuLynx
Ok!
15:15
BAndiT1983
and also merging etc.
15:15
BAndiT1983
i will resolve it by hand now and we will see what CI will output
15:15
TofuLynx
Roger! :)
15:16
TofuLynx
I have yet to implement Travis CI on my repo
15:17
BAndiT1983
it's just a checkbox in travis ci, aas the script is always the same
15:18
BAndiT1983
build will fail of course, but as explained yesterday, because of tests and is done on purpose for now
15:21
BAndiT1983
TofuLynx, build fails because of some other problems ->
15:21
BAndiT1983
https://travis-ci.org/apertus-open-source-cinema/opencine/builds/373508737?utm_source=github_status&utm_medium=notification
15:21
illwieckz
joined the channel
15:21
TofuLynx
hmm
15:22
TofuLynx
I see
15:22
TofuLynx
Did you check the class?
15:23
BAndiT1983
nope
15:23
TofuLynx
Okki, I will eat something right now, maybe some pancakes xD
15:23
TofuLynx
I will be right back
15:24
BAndiT1983
ok
15:25
BAndiT1983
TofuLynx, you have renamed already available class, so it's crashing, why was renaming important?
16:05
ArunM
left the channel
16:07
TofuLynx
I didn't rename, I created a new class with a new name.
16:10
BAndiT1983
why?
16:11
BAndiT1983
there is already one for bilinear interpolation, which was removed, according to git
16:14
TofuLynx
Basically, I want to name my classes the following: Debayer<Something>
16:14
TofuLynx
so it's organized and easy to access
16:15
BAndiT1983
ehm, there is already code in the project which you should follow for now
16:15
BAndiT1983
everything else should be discussed
16:16
TofuLynx
which code?
16:16
BAndiT1983
available class structure or do you want to replace everything just like that?
16:17
BAndiT1983
when things should be changed, then bit by bit
16:17
TofuLynx
Well I just created a new debayer class from raw, wasn't expecting so much trouble here xD
16:17
TofuLynx
I think I will keep doing it from raw for the other algorithms too
16:17
TofuLynx
what do you think?
16:18
BAndiT1983
classes are already there, so why not use them first for now?
16:19
TofuLynx
hmm, which classes? I only saw the BilinearDebayer and Interpolation ones
16:19
BAndiT1983
so, and what about this classes? ->https://github.com/apertus-open-source-cinema/opencine/tree/master/Source/OCcore/Image
16:20
BAndiT1983
there are already prepared classes there and i have not mucht intent to change everything for now, as clean up will do more trouble while preparing stuff
16:20
TofuLynx
wait wait
16:20
TofuLynx
what I am saying
16:21
TofuLynx
is that i just want to replace the already existing BilinearDebayer
16:21
TofuLynx
just that
16:21
TofuLynx
and I will create more classes for Green Directed and SHOODAK
16:22
TofuLynx
(Actually, SHOODAK one should replace the existing shoodak class)
16:22
g3gg0
left the channel
16:22
BAndiT1983
greend edge is GEDIDebayer, SHOODAK is also there
16:22
BAndiT1983
it's everything there, so please stick to current classes for now
16:23
TofuLynx
Oh! I see
16:23
TofuLynx
Didn't saw those
16:23
TofuLynx
hmm
16:23
BAndiT1983
just ask in case you are not sure
16:23
TofuLynx
also, why not rename to Debayer<Type> ?
16:23
BAndiT1983
what is the advantage?
16:24
TofuLynx
it's more organized, specially on lists alphabetically sorted
16:25
BAndiT1983
don't see it as important at the moment with just a couple of classes for debayering, also usually the type is in front and action at the end of names
16:26
TofuLynx
Okki! Do you want me to rename my class?
16:26
BAndiT1983
please do it for now, otherwise i have to clean up every time something is renamed and crashes
16:27
BAndiT1983
postpone bigger things for later, focus on functionality
16:27
TofuLynx
yeah makes sense, sorry!
16:28
BAndiT1983
no problem, just trying to explain why the things are structured like that at the moment, mostly historical reason, but some things have come from several standard ways
16:28
BAndiT1983
Image folder will get some sub-folders also, like DebayerAlgorithms or so
16:29
TofuLynx
Roger!
16:29
TofuLynx
can you explain me one thing?
16:30
TofuLynx
#ifndef GEDIDEBAYER_H
16:30
TofuLynx
#define GEDIDEBAYER_H
16:30
TofuLynx
what does this do?
16:30
TofuLynx
and this
16:30
TofuLynx
#endif //GEDIDEBAYER_H
16:31
BAndiT1983
it prevents multiple re-definitions, they are calles header guards
16:31
BAndiT1983
*called
16:31
BAndiT1983
https://en.wikipedia.org/wiki/Include_guard
16:35
TofuLynx
Ah! Okk!
16:39
BAndiT1983
TofuLynx, also think about how to test algorithms, will add an example for pixel extraction, but it can also be adjusted for debayering
16:39
supragya
joined the channel
16:40
TofuLynx
How did you do the pixel extraction unit tests?
16:40
BAndiT1983
i will pastebin current state, bit it's not complete yet
16:42
BAndiT1983
https://pastebin.com/HNntg07Y
16:42
ArunM
joined the channel
16:43
BAndiT1983
ah, just found a copy/paste error, blue array should contain 3s and not 1s
16:44
TofuLynx
Ok! Makes sense!
16:45
TofuLynx
I think we could reuse your unit tests by changing the exxpected values
16:45
BAndiT1983
yep, also that, but some structural adjustments have also to be done, as it's rather problematic to do separate processing
16:46
TofuLynx
hmm what do you mean by separate processing?
16:48
BAndiT1983
bit conversion and pixel extraction are done in one method, but for that you have to know the format etc.
16:48
BAndiT1983
e.g. thinking about where to store 12bit or 14bit format info
16:55
TofuLynx
i will be off for now
16:55
BAndiT1983
ok, see you
16:55
TofuLynx
See you later!
16:56
TofuLynx
left the channel
17:17
supragya
hi BAndiT1983 !!
17:17
BAndiT1983
hi supragya
17:17
supragya
Can you audit this design for me please: http://supragyaraj.com/
17:19
BAndiT1983
looks interesting
17:20
BAndiT1983
there is a space missing for the links at the bottom -> http://blog.supragyaraj.com
17:21
supragya
footer?
17:21
BAndiT1983
Supragya Raj's Blog: HomeGitHub
17:21
BAndiT1983
between home and github
17:21
supragya
ah yes
17:21
BAndiT1983
resume is missing at the moment
17:21
supragya
much of it is missing at the moment
17:22
supragya
the main page was made entirely today :)
17:22
BAndiT1983
overall really good, here and there a comma in text missing, but it's not that important
17:22
supragya
other things have to be put in place
17:22
BAndiT1983
do you ever sleep?
17:22
supragya
seldom
17:22
BAndiT1983
sleep is important, to stay productive
17:23
supragya
have heard that quite a few times now :)
17:23
BAndiT1983
opposite to the idea of some managers, that working longer (e.g. per day) will get projects done, it's not true
17:24
supragya
that's my state now
17:24
supragya
exhausted after selecting colors from over 100 palettes
17:24
supragya
just to make it look right
17:25
BAndiT1983
personal observation is, that the performance degrades after some hours of concentrated work, it degrades even faster when getting distracted, like big office or calls from colleagues
17:26
supragya
taking a short nap, and a few pushups give a few hours more... but exactly what you said BAndiT1983
17:26
supragya
If it weren't for boards... I wouldn't know how much I have to do
17:26
supragya
and trello is just for GSoC, have 2 personal boards for myself :)
17:27
supragya
atleast I have completed today's tasks... tomorrow I have more time to look at formats
17:27
BAndiT1983
know that all too good
17:29
supragya
Going to sleep now (23:00), have to wake at 4 maybe.... (need to reaudit the irc logs...)
17:29
BAndiT1983
ehm, that's not much sleep
17:30
supragya
I have afternoon naps... don't worry
17:30
BAndiT1983
you should re-adjust your day, otherwise it will take revenge on you later in life
17:30
supragya
and I cannot wake after 4... I am at home... and remember... my dad is in militart
17:30
supragya
*military
17:30
BAndiT1983
:)
17:31
supragya
[afternoon naps] -> beats heat when you don't wanna work
17:31
supragya
Good day ahead BAndiT1983 :)
17:31
BAndiT1983
usually they shouldn't be long, maximum half an hour, to prevent deep sleep
17:31
BAndiT1983
have a good night
17:32
supragya
left the channel
18:02
se6astian|away
changed nick to: se6astian
18:09
intrac
left the channel
18:51
BAndiT1983
changed nick to: BAndiT1983|away
19:07
ArunM
left the channel
19:09
ArunM
joined the channel
19:30
BAndiT1983|away
changed nick to: BAndiT1983
19:32
ArunM
left the channel
20:52
RexOrCine
changed nick to: RexOrCine|away
21:06
se6astian
changed nick to: se6astian|away
21:08
BAndiT1983
changed nick to: BAndiT1983|away
21:25
niemand
left the channel
21:34
intrac
joined the channel
23:21
futarisIRCcloud
joined the channel
23:33
BAndiT1983|away
changed nick to: BAndiT1983