| 01:59 | seaman_ | left the channel |
| 02:23 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 02:35 | intrac | left the channel |
| 02:50 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 03:27 | rton | left the channel |
| 04:29 | slikdigit | left the channel |
| 04:55 | futarisIRCcloud | joined the channel |
| 05:13 | Bertl_oO | off to bed now ... have a good one!
|
| 05:13 | Bertl_oO | changed nick to: Bertl_zZ
|
| 05:19 | intrac | joined the channel |
| 08:24 | niemand | joined the channel |
| 08:47 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 09:24 | se6astian|away | changed nick to: se6astian
|
| 09:27 | se6astian | changed nick to: se6astian|away
|
| 10:35 | rton | joined the channel |
| 11:08 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 12:06 | g3gg0 | joined the channel |
| 12:10 | seaman | joined the channel |
| 12:33 | ArunM | joined the channel |
| 12:59 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 12:59 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 13:14 | futarisIRCcloud | left the channel |
| 13:18 | Bertl_zZ | changed nick to: Bertl
|
| 13:18 | Bertl | morning folks!
|
| 13:29 | ArunM | left the channel |
| 13:33 | ArunM | joined the channel |
| 13:50 | RexOrCine|away | changed nick to: RexOrCine
|
| 14:18 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 14:43 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 14:43 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 15:17 | TofuLynx | joined the channel |
| 15:47 | TofuLynx | Good Afternoon!
|
| 15:55 | TofuLynx | BAndiT1983: You there?
|
| 15:57 | BAndiT1983 | hi TofuLynx, now i am
|
| 15:59 | TofuLynx | Hey!
|
| 16:00 | TofuLynx | I finished the bilinear debayer class, I will commit it now to my repo. Can you check it? I still have to structure it better and add patternOffsets
|
| 16:02 | BAndiT1983 | just do a pull request and travis ci will build it first, will look at it in parallel
|
| 16:03 | TofuLynx | ok!
|
| 16:07 | illwieckz | left the channel |
| 16:08 | BAndiT1983 | TofuLynx, quick reboot
|
| 16:08 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 16:12 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 16:12 | TofuLynx | Hello
|
| 16:13 | TofuLynx | I made the PR, it has one conflict, can you solve it, please?
|
| 16:13 | TofuLynx | It is related to changes you made
|
| 16:13 | BAndiT1983 | let me check it first, apps are still starting after reboot
|
| 16:13 | BAndiT1983 | somehow hyper-v was activated after big update today, so had to get rid of it for virtualbox
|
| 16:13 | TofuLynx | ok! :)
|
| 16:14 | BAndiT1983 | hayve you pulled first?
|
| 16:14 | TofuLynx | nope
|
| 16:14 | TofuLynx | wait
|
| 16:14 | TofuLynx | yes*
|
| 16:14 | TofuLynx | i think so
|
| 16:14 | BAndiT1983 | that's the problem, as the newer code is different in the place of conflict
|
| 16:15 | TofuLynx | I didn't pull the PreProcessor
|
| 16:15 | TofuLynx | As I made changes on it
|
| 16:15 | BAndiT1983 | you should always pull everything, before committing
|
| 16:15 | TofuLynx | Ok!
|
| 16:15 | BAndiT1983 | and also merging etc.
|
| 16:15 | BAndiT1983 | i will resolve it by hand now and we will see what CI will output
|
| 16:15 | TofuLynx | Roger! :)
|
| 16:16 | TofuLynx | I have yet to implement Travis CI on my repo
|
| 16:17 | BAndiT1983 | it's just a checkbox in travis ci, aas the script is always the same
|
| 16:18 | BAndiT1983 | build will fail of course, but as explained yesterday, because of tests and is done on purpose for now
|
| 16:21 | BAndiT1983 | TofuLynx, build fails because of some other problems ->
|
| 16:21 | BAndiT1983 | https://travis-ci.org/apertus-open-source-cinema/opencine/builds/373508737?utm_source=github_status&utm_medium=notification
|
| 16:21 | illwieckz | joined the channel |
| 16:21 | TofuLynx | hmm
|
| 16:22 | TofuLynx | I see
|
| 16:22 | TofuLynx | Did you check the class?
|
| 16:23 | BAndiT1983 | nope
|
| 16:23 | TofuLynx | Okki, I will eat something right now, maybe some pancakes xD
|
| 16:23 | TofuLynx | I will be right back
|
| 16:24 | BAndiT1983 | ok
|
| 16:25 | BAndiT1983 | TofuLynx, you have renamed already available class, so it's crashing, why was renaming important?
|
| 17:05 | ArunM | left the channel |
| 17:07 | TofuLynx | I didn't rename, I created a new class with a new name.
|
| 17:10 | BAndiT1983 | why?
|
| 17:11 | BAndiT1983 | there is already one for bilinear interpolation, which was removed, according to git
|
| 17:14 | TofuLynx | Basically, I want to name my classes the following: Debayer<Something>
|
| 17:14 | TofuLynx | so it's organized and easy to access
|
| 17:15 | BAndiT1983 | ehm, there is already code in the project which you should follow for now
|
| 17:15 | BAndiT1983 | everything else should be discussed
|
| 17:16 | TofuLynx | which code?
|
| 17:16 | BAndiT1983 | available class structure or do you want to replace everything just like that?
|
| 17:17 | BAndiT1983 | when things should be changed, then bit by bit
|
| 17:17 | TofuLynx | Well I just created a new debayer class from raw, wasn't expecting so much trouble here xD
|
| 17:17 | TofuLynx | I think I will keep doing it from raw for the other algorithms too
|
| 17:17 | TofuLynx | what do you think?
|
| 17:18 | BAndiT1983 | classes are already there, so why not use them first for now?
|
| 17:19 | TofuLynx | hmm, which classes? I only saw the BilinearDebayer and Interpolation ones
|
| 17:19 | BAndiT1983 | so, and what about this classes? ->https://github.com/apertus-open-source-cinema/opencine/tree/master/Source/OCcore/Image
|
| 17:20 | BAndiT1983 | there are already prepared classes there and i have not mucht intent to change everything for now, as clean up will do more trouble while preparing stuff
|
| 17:20 | TofuLynx | wait wait
|
| 17:20 | TofuLynx | what I am saying
|
| 17:21 | TofuLynx | is that i just want to replace the already existing BilinearDebayer
|
| 17:21 | TofuLynx | just that
|
| 17:21 | TofuLynx | and I will create more classes for Green Directed and SHOODAK
|
| 17:22 | TofuLynx | (Actually, SHOODAK one should replace the existing shoodak class)
|
| 17:22 | g3gg0 | left the channel |
| 17:22 | BAndiT1983 | greend edge is GEDIDebayer, SHOODAK is also there
|
| 17:22 | BAndiT1983 | it's everything there, so please stick to current classes for now
|
| 17:23 | TofuLynx | Oh! I see
|
| 17:23 | TofuLynx | Didn't saw those
|
| 17:23 | TofuLynx | hmm
|
| 17:23 | BAndiT1983 | just ask in case you are not sure
|
| 17:23 | TofuLynx | also, why not rename to Debayer<Type> ?
|
| 17:23 | BAndiT1983 | what is the advantage?
|
| 17:24 | TofuLynx | it's more organized, specially on lists alphabetically sorted
|
| 17:25 | BAndiT1983 | don't see it as important at the moment with just a couple of classes for debayering, also usually the type is in front and action at the end of names
|
| 17:26 | TofuLynx | Okki! Do you want me to rename my class?
|
| 17:26 | BAndiT1983 | please do it for now, otherwise i have to clean up every time something is renamed and crashes
|
| 17:27 | BAndiT1983 | postpone bigger things for later, focus on functionality
|
| 17:27 | TofuLynx | yeah makes sense, sorry!
|
| 17:28 | BAndiT1983 | no problem, just trying to explain why the things are structured like that at the moment, mostly historical reason, but some things have come from several standard ways
|
| 17:28 | BAndiT1983 | Image folder will get some sub-folders also, like DebayerAlgorithms or so
|
| 17:29 | TofuLynx | Roger!
|
| 17:29 | TofuLynx | can you explain me one thing?
|
| 17:30 | TofuLynx | #ifndef GEDIDEBAYER_H
|
| 17:30 | TofuLynx | #define GEDIDEBAYER_H
|
| 17:30 | TofuLynx | what does this do?
|
| 17:30 | TofuLynx | and this
|
| 17:30 | TofuLynx | #endif //GEDIDEBAYER_H
|
| 17:31 | BAndiT1983 | it prevents multiple re-definitions, they are calles header guards
|
| 17:31 | BAndiT1983 | *called
|
| 17:31 | BAndiT1983 | https://en.wikipedia.org/wiki/Include_guard
|
| 17:35 | TofuLynx | Ah! Okk!
|
| 17:39 | BAndiT1983 | TofuLynx, also think about how to test algorithms, will add an example for pixel extraction, but it can also be adjusted for debayering
|
| 17:39 | supragya | joined the channel |
| 17:40 | TofuLynx | How did you do the pixel extraction unit tests?
|
| 17:40 | BAndiT1983 | i will pastebin current state, bit it's not complete yet
|
| 17:42 | BAndiT1983 | https://pastebin.com/HNntg07Y
|
| 17:42 | ArunM | joined the channel |
| 17:43 | BAndiT1983 | ah, just found a copy/paste error, blue array should contain 3s and not 1s
|
| 17:44 | TofuLynx | Ok! Makes sense!
|
| 17:45 | TofuLynx | I think we could reuse your unit tests by changing the exxpected values
|
| 17:45 | BAndiT1983 | yep, also that, but some structural adjustments have also to be done, as it's rather problematic to do separate processing
|
| 17:46 | TofuLynx | hmm what do you mean by separate processing?
|
| 17:48 | BAndiT1983 | bit conversion and pixel extraction are done in one method, but for that you have to know the format etc.
|
| 17:48 | BAndiT1983 | e.g. thinking about where to store 12bit or 14bit format info
|
| 17:55 | TofuLynx | i will be off for now
|
| 17:55 | BAndiT1983 | ok, see you
|
| 17:55 | TofuLynx | See you later!
|
| 17:56 | TofuLynx | left the channel |
| 18:17 | supragya | hi BAndiT1983 !!
|
| 18:17 | BAndiT1983 | hi supragya
|
| 18:17 | supragya | Can you audit this design for me please: http://supragyaraj.com/
|
| 18:19 | BAndiT1983 | looks interesting
|
| 18:20 | BAndiT1983 | there is a space missing for the links at the bottom -> http://blog.supragyaraj.com
|
| 18:21 | supragya | footer?
|
| 18:21 | BAndiT1983 | Supragya Raj's Blog: HomeGitHub
|
| 18:21 | BAndiT1983 | between home and github
|
| 18:21 | supragya | ah yes
|
| 18:21 | BAndiT1983 | resume is missing at the moment
|
| 18:21 | supragya | much of it is missing at the moment
|
| 18:22 | supragya | the main page was made entirely today :)
|
| 18:22 | BAndiT1983 | overall really good, here and there a comma in text missing, but it's not that important
|
| 18:22 | supragya | other things have to be put in place
|
| 18:22 | BAndiT1983 | do you ever sleep?
|
| 18:22 | supragya | seldom
|
| 18:22 | BAndiT1983 | sleep is important, to stay productive
|
| 18:23 | supragya | have heard that quite a few times now :)
|
| 18:23 | BAndiT1983 | opposite to the idea of some managers, that working longer (e.g. per day) will get projects done, it's not true
|
| 18:24 | supragya | that's my state now
|
| 18:24 | supragya | exhausted after selecting colors from over 100 palettes
|
| 18:24 | supragya | just to make it look right
|
| 18:25 | BAndiT1983 | personal observation is, that the performance degrades after some hours of concentrated work, it degrades even faster when getting distracted, like big office or calls from colleagues
|
| 18:26 | supragya | taking a short nap, and a few pushups give a few hours more... but exactly what you said BAndiT1983
|
| 18:26 | supragya | If it weren't for boards... I wouldn't know how much I have to do
|
| 18:26 | supragya | and trello is just for GSoC, have 2 personal boards for myself :)
|
| 18:27 | supragya | atleast I have completed today's tasks... tomorrow I have more time to look at formats
|
| 18:27 | BAndiT1983 | know that all too good
|
| 18:29 | supragya | Going to sleep now (23:00), have to wake at 4 maybe.... (need to reaudit the irc logs...)
|
| 18:29 | BAndiT1983 | ehm, that's not much sleep
|
| 18:30 | supragya | I have afternoon naps... don't worry
|
| 18:30 | BAndiT1983 | you should re-adjust your day, otherwise it will take revenge on you later in life
|
| 18:30 | supragya | and I cannot wake after 4... I am at home... and remember... my dad is in militart
|
| 18:30 | supragya | *military
|
| 18:30 | BAndiT1983 | :)
|
| 18:31 | supragya | [afternoon naps] -> beats heat when you don't wanna work
|
| 18:31 | supragya | Good day ahead BAndiT1983 :)
|
| 18:31 | BAndiT1983 | usually they shouldn't be long, maximum half an hour, to prevent deep sleep
|
| 18:31 | BAndiT1983 | have a good night
|
| 18:32 | supragya | left the channel |
| 19:02 | se6astian|away | changed nick to: se6astian
|
| 19:09 | intrac | left the channel |
| 19:51 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 20:07 | ArunM | left the channel |
| 20:09 | ArunM | joined the channel |
| 20:30 | BAndiT1983|away | changed nick to: BAndiT1983
|
| 20:32 | ArunM | left the channel |
| 21:52 | RexOrCine | changed nick to: RexOrCine|away
|
| 22:06 | se6astian | changed nick to: se6astian|away
|
| 22:08 | BAndiT1983 | changed nick to: BAndiT1983|away
|
| 22:25 | niemand | left the channel |
| 22:34 | intrac | joined the channel |
| 00:21 | futarisIRCcloud | joined the channel |
| 00:33 | BAndiT1983|away | changed nick to: BAndiT1983
|